Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing location re-enables atmosphere 23.1.141-c98b3c9 #3250

Closed
axd1967 opened this issue May 30, 2023 · 6 comments · Fixed by #3180
Closed

changing location re-enables atmosphere 23.1.141-c98b3c9 #3250

axd1967 opened this issue May 30, 2023 · 6 comments · Fixed by #3180
Assignees
Labels
opinion OP thinks something should behave differently
Milestone

Comments

@axd1967
Copy link
Contributor

axd1967 commented May 30, 2023

Expected Behaviour

When disabling atmosphere and moving around, atmosphere should remain off

Actual Behaviour

Atmosphere is re-activated

Steps to reproduce

  1. disable atmosphere (A)
  2. open location dialog (F6)
  3. move location

Bug: atmosphere is enabled

System

  • Stellarium version: 23.1.141-c98b3c9

Operating System: Kubuntu 20.04
KDE Plasma Version: 5.18.8
KDE Frameworks Version: 5.68.0
Qt Version: 5.12.8
Kernel Version: 5.4.0-148-generic
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-10510U CPU @ 1.80GHz
Memory: 15.3 GiB of RAM

Logfile

If possible, attach the logfile log.txt from your user data directory. Look into the Guide for its location.

@alex-w
Copy link
Member

alex-w commented May 30, 2023

I guess the option for automatic enabling the environment is enabled in settings, so, in this case this is not a bug

@alex-w alex-w added the opinion OP thinks something should behave differently label May 30, 2023
@axd1967
Copy link
Contributor Author

axd1967 commented May 30, 2023

I guess the option for automatic enabling the environment is enabled in settings, so, in this case this is not a bug

Which setting would that be?

image
image

@axd1967
Copy link
Contributor Author

axd1967 commented May 30, 2023

Aha, this one

image

@axd1967
Copy link
Contributor Author

axd1967 commented May 30, 2023

I think that setting should have an influence only when jumping to another body, not while moving around on a body.

The description clearly says so:

\item[Auto-enabling for the environment] When changing planet during
location change, atmosphere will be switched as required.

and

<label><input class="stelproperty" name="LandscapeMgr.flagEnvironmentAutoEnabling" type="checkbox"/><?= tr("Auto-enabling for the environment")?></label>

so, only when changing planet.

also, the description should read "when changing the body" (because this also works for e.g Vesta, even if it doesn't make much sense: if auto enable is set, this will also set atmosphere when jumping from Earth to Vesta).

@gzotti
Copy link
Member

gzotti commented May 30, 2023

#3180

@alex-w alex-w added this to the 23.2 milestone Jun 16, 2023
@gzotti gzotti linked a pull request Jun 16, 2023 that will close this issue
17 tasks
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Jun 18, 2023
@github-actions
Copy link

Hello @axd1967!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opinion OP thinks something should behave differently
Development

Successfully merging a pull request may close this issue.

3 participants