Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoebe position iincorrect #230

Closed
kwbeverage opened this issue Jul 25, 2018 · 10 comments
Closed

Phoebe position iincorrect #230

kwbeverage opened this issue Jul 25, 2018 · 10 comments
Assignees
Labels
data Missing/bad/outdated data, but no code error enhancement Improve existing functionality help wanted We may not have the hardware or expertise
Milestone

Comments

@kwbeverage
Copy link

Expected Behaviour

Correct position shown for Phoebe

Actual Behaviour

For a given time Phoebe is shown in an incorrect location. Checked results against ephemerides acquired from the MPC Natural Satellites Ephemeris Service and Saturn Viewer 2.9 website. See screen capture and text file for comparison.

Steps to reproduce

Installed current version (0.18.1) which shows the same position as previous install (0.17.0).

System

  • Stellarium version: stellarium-0.18.1-win64
  • Operating system: Windows 10, version 1803
  • Graphics Card: NVidia GEFORCE GTX 950m

Logfile

No logfile available

Attachments:
stellarium-014

phoebe_data.txt

@gzotti
Copy link
Member

gzotti commented Jul 25, 2018

https://github.com/Stellarium/stellarium/wiki/FAQ#some-moons-are-in-another-position-than-they-should-be

Stellarium is not finished. You are cordially invited to help.

@gzotti gzotti added enhancement Improve existing functionality help wanted We may not have the hardware or expertise importance: low Small problem, rarely visible, no crash labels Jul 25, 2018
@alex-w
Copy link
Member

alex-w commented Jul 27, 2018

Phoebe has simple elliptic orbit at the moment and of course this solution is not accurate. We need to implement PH12 (ftp://ftp.imcce.fr/pub/ephem/satel/ph12/README.txt) and HTC 2.0 (ftp://ftp.imcce.fr/pub/ephem/satel/htc20/ReadMe.txt) for Saturnian moons.

@alex-w alex-w removed the importance: low Small problem, rarely visible, no crash label Jun 20, 2021
@piellepi
Copy link

piellepi commented Dec 14, 2022

hi!
I'm using version 1.1 of stellarium but Phoebe's position is still greatly incorrect.
instead in stellarium web the position seems correct and comparable to the one generated by IMCCE software

this is the position in PC version
febe pc

this is in the web version
febe web

and this is the position from IMCCE
febe imcce
Phobe here is marked with a cross...

thanks
Pierluigi Panunzi

@gzotti
Copy link
Member

gzotti commented Dec 14, 2022

Yes, and therefore this issue is still open.

@worachate001
Copy link
Member

I'm investigating the cause of error and found that orbital elements of the satellite are wrong for the epoch. I will correct it soon and try to check (and correct them if needed) others before the release of version 23.2.

@worachate001 worachate001 self-assigned this Jun 15, 2023
@alex-w alex-w added the data Missing/bad/outdated data, but no code error label Jun 15, 2023
@gzotti
Copy link
Member

gzotti commented Jun 15, 2023

@alex-w mentioned PH12, so this (or even better) would be preferred over Kepler elements.

@worachate001
Copy link
Member

I read that PH12 ephemeris is available for only the years 1875-2022. The alternative method that I'm thinking about is using mean orbital elements that include rate of changes (in longitude of ascending node, etc.) , derived from hundred years of elements. But it would be original work.

@gzotti
Copy link
Member

gzotti commented Jun 15, 2023

OK, yes, PH12 is no solution then. Note that the current way to describe moon orbits is relative to the planet equator, which is not what is usually found in the literature. I don't know the origin of this model. If you make variable orbits like this, you must also change the KeplerOrbit class.

@worachate001 worachate001 added this to the 23.2 milestone Jun 16, 2023
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Jun 18, 2023
@github-actions
Copy link

Hello @kwbeverage!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Jul 2, 2023
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Hello @kwbeverage!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Missing/bad/outdated data, but no code error enhancement Improve existing functionality help wanted We may not have the hardware or expertise
Development

No branches or pull requests

5 participants