Use a different alias for Dynamic provider so we control the min level. Filter the filterOptions so that only applicable filters are applied [fixes #152855242]

Author: Tim Hess

src/Steeltoe.Extensions.Logging.DynamicLogger/DynamicLoggerProvider.cs

@@ -22,7 +22,7 @@
 
 namespace Steeltoe.Extensions.Logging
 {
-    [ProviderAlias("Console")]
+    [ProviderAlias("Dynamic")]
     public class DynamicLoggerProvider : IDynamicLoggerProvider
     {
         private Func<string, LogLevel, bool> _filter;
@@ -198,7 +198,7 @@ public void SetLogLevel(string category, LogLevel? level)
 
         private void SetFiltersFromOptions()
         {
-            foreach (var rule in _filterOptions.CurrentValue.Rules)
+            foreach (var rule in _filterOptions.CurrentValue.Rules.Where(p => string.IsNullOrEmpty(p.ProviderName) || p.ProviderName == "Console"))
             {
                 if (rule.CategoryName == "Default" || string.IsNullOrEmpty(rule.CategoryName))
                 {
@@ -285,6 +285,8 @@ private Func<string, LogLevel, bool> GetFilter(string name)
                         return _runningFilters.First(f => f.Key == prefix).Value;
                     }
                 }
+
+                return _filter;
             }
 
             // check if there are any applicable settings

test/Steeltoe.Extensions.Logging.DynamicLogger.Test/DynamicLoggingBuilderTest.cs

@@ -26,10 +26,69 @@ public class DynamicLoggingBuilderTest
         {
             ["Logging:IncludeScopes"] = "false",
             ["Logging:Console:LogLevel:Default"] = "Information",
+            ["Logging:Console:LogLevel:A.B.C.D"] = "Critical",
             ["Logging:LogLevel:Steeltoe.Extensions.Logging.Test"] = "Information",
             ["Logging:LogLevel:Default"] = "Warning"
         };
 
+        [Fact]
+        public void OnlyApplicableFilters_AreApplied()
+        {
+            // arrange
+            var _appsettings = new Dictionary<string, string>()
+            {
+                ["Logging:IncludeScopes"] = "false",
+                ["Logging:LogLevel:Default"] = "Information",
+                ["Logging:foo:LogLevel:A.B.C.D.TestClass"] = "None"
+            };
+            var configuration = new ConfigurationBuilder().AddInMemoryCollection(_appsettings).Build();
+            var services = new ServiceCollection()
+                .AddLogging(builder =>
+                {
+                    builder.AddConfiguration(configuration.GetSection("Logging"));
+                    builder.AddDynamicConsole();
+                })
+                .BuildServiceProvider();
+
+            // act
+            var logger = services.GetService(typeof(ILogger<A.B.C.D.TestClass>)) as ILogger<A.B.C.D.TestClass>;
+
+            // assert
+            Assert.NotNull(logger);
+            Assert.True((logger).IsEnabled(LogLevel.Information), "Information level should be enabled");
+            Assert.False((logger).IsEnabled(LogLevel.Debug), "Debug level should NOT be enabled");
+        }
+
+        [Fact]
+        public void DynamicLevelSetting_WorksWith_ConsoleFilters()
+        {
+            // arrange
+            var configuration = new ConfigurationBuilder().AddInMemoryCollection(appsettings).Build();
+            var services = new ServiceCollection()
+                .AddLogging(builder =>
+                {
+                    builder.AddConfiguration(configuration.GetSection("Logging"));
+                    builder.AddDynamicConsole();
+                })
+                .BuildServiceProvider();
+
+            // act
+            var logger = services.GetService(typeof(ILogger<A.B.C.D.TestClass>)) as ILogger<A.B.C.D.TestClass>;
+
+            // assert
+            Assert.NotNull(logger);
+            Assert.True((logger).IsEnabled(LogLevel.Critical), "Critical level should be enabled");
+            Assert.False((logger).IsEnabled(LogLevel.Error), "Error level should NOT be enabled");
+            Assert.False((logger).IsEnabled(LogLevel.Warning), "Warning level should NOT be enabled");
+            Assert.False((logger).IsEnabled(LogLevel.Debug), "Debug level should NOT be enabled");
+            Assert.False((logger).IsEnabled(LogLevel.Trace), "Trace level should NOT be enabled yet");
+
+            // change the log level and confirm it worked
+            var provider = services.GetRequiredService(typeof(ILoggerProvider)) as DynamicLoggerProvider;
+            provider.SetLogLevel("A.B.C.D", LogLevel.Trace);
+            Assert.True((logger).IsEnabled(LogLevel.Trace), "Trace level should have been enabled");
+        }
+
         [Fact]
         public void AddConsole_Works_WithAddConfiguration()
         {