Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opengraph image for social #65

Closed
kentonh opened this issue Oct 11, 2016 · 10 comments · Fixed by #113
Closed

Fix opengraph image for social #65

kentonh opened this issue Oct 11, 2016 · 10 comments · Fixed by #113

Comments

@kentonh
Copy link
Member

kentonh commented Oct 11, 2016

Right now anytime anyone posts anything to Facebook, my face shows up. That's nice and all, but I'd prefer something like our logo be used.

By default use the svg logo of the site available here:
sw_logo_dark
sw_mark_dark

Issue #86 would add the ability to use the Social Graph image of the article or event that is being reposted. That may be a better option.

@BhaveshSGupta
Copy link

Hi, The minimum image size for og: image should be 200*200, please refer to this https://developers.facebook.com/docs/sharing/best-practices,
ogimage

I guess we can update the current image to minimum size, I can take this up

@kentonh
Copy link
Member Author

kentonh commented Oct 11, 2016

@BhaveshSGupta
Copy link

BhaveshSGupta commented Oct 11, 2016

I am making it to 200*200, where should i make the PR to into which branch ? can you help me in making these changes thanks

@kentonh
Copy link
Member Author

kentonh commented Oct 12, 2016

PR into the Master branch, thanks

@AustinMCrane
Copy link

I got this

@kentonh
Copy link
Member Author

kentonh commented Sep 25, 2017

No one is working on this

@BhaveshSGupta
Copy link

I remember I was not able to find the place to replace the image and run the project locally
I think image needs to be replaced in this two file

<meta property="og:image" content="/assets/tophandlogo-02.png">
<meta property="og:image" content="<%= image_path 'tophandlogo-02.png' %>">

and Still trying to figure out how to run this locally

@kentonh
Copy link
Member Author

kentonh commented Sep 26, 2017

@BhaveshSGupta no problem. I'm just setting up this issue for this year's Hacktoberfest

@lafentres
Copy link
Contributor

@kentonh , I could fix this. I noticed a couple of other issues when I was looking at this as well.

  1. The meta tags don't dynamically pull in the request url, so any share from any page (like /events for example), will always point back to the homepage.
  2. Not a huge issue really, but the title for the share doesn't change.

I could fix these as well and any other sharing things I notice.

@kentonh
Copy link
Member Author

kentonh commented Oct 3, 2017

@lafentres that'd be awesome! Thanks.

kentonh added a commit that referenced this issue Oct 4, 2017
Facebook/Twitter social sharing tags & page titles. Closes #65 

Thanks @lafentres 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants