Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] support create/drop/query iceberg view for hive catalog #55448

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[Feature] support create/drop/query iceberg view for hive catalog #55448

merged 1 commit into from
Jan 27, 2025

Conversation

Youngwb
Copy link
Contributor

@Youngwb Youngwb commented Jan 26, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

support create/drop/query iceberg view for hive catalog
Fixes #55449

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@Youngwb Youngwb requested a review from a team as a code owner January 26, 2025 03:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 36 / 41 (87.80%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/iceberg/IcebergApiConverter.java 7 9 77.78% [436, 447]
🔵 com/starrocks/connector/iceberg/hive/IcebergHiveCatalog.java 7 8 87.50% [221]
🔵 com/starrocks/connector/iceberg/IcebergCatalog.java 19 21 90.48% [125, 171]
🔵 com/starrocks/connector/iceberg/rest/IcebergRESTCatalog.java 1 1 100.00% []
🔵 com/starrocks/connector/iceberg/CachingIcebergCatalog.java 1 1 100.00% []
🔵 com/starrocks/connector/iceberg/IcebergMetadata.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@stdpain stdpain merged commit ec7e5e3 into StarRocks:main Jan 27, 2025
47 of 49 checks passed
@Youngwb Youngwb deleted the ice_hive_view branch January 27, 2025 02:10
@wanpengfei-git wanpengfei-git mentioned this pull request Jan 27, 2025
Open
1 task
@Youngwb
Copy link
Contributor Author

Youngwb commented Jan 27, 2025

@mergify backport branch-3.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 27, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 27, 2025
@Youngwb @mergify
[Feature] support create/drop/query iceberg view for hive catalog (#5…
c7d6c17 
…5448)

(cherry picked from commit ec7e5e3)
@mergify mergify bot mentioned this pull request Jan 27, 2025
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Jan 27, 2025
@mergify @Youngwb
[Feature] support create/drop/query iceberg view for hive catalog (ba…
269746b 
…ckport #55448) (#55486)

Co-authored-by: Youngwb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdpain stdpain stdpain approved these changes

@dirtysalt dirtysalt dirtysalt approved these changes

Assignees

@Youngwb Youngwb

Labels
3.4-merged version:3.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support create/query/drop iceberg view for hive catalog
3 participants
@Youngwb @dirtysalt @stdpain