Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong "CheckSystemCall" is called #3

Open
sadjad opened this issue Apr 16, 2020 · 0 comments
Open

Wrong "CheckSystemCall" is called #3

sadjad opened this issue Apr 16, 2020 · 0 comments

Comments

@sadjad
Copy link
Member

sadjad commented Apr 16, 2020

https://github.com/keithw/mush/blob/99b598a4366bb10cfe4326703b3af39925a58a12/src/util/socket.cc#L15

Here we are calling Socket::CheckSystemCall, not the CheckSystemCall from exception.hh. As the _internal_fd is not initialized yet, we're effectively calling a function on a null pointer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sadjad