Skip to content

Commit ed186e5

Browse files
committed
Use MCP_TRANSPORT environment variable
Replace TRANSPORT with MCP_TRANSPORT for transport type configuration. This enables out-of-the-box compatibility with ToolHive, which sets MCP_TRANSPORT as the default environment variable for MCP servers. Resolves #53 Signed-off-by: Syed Azeez <[email protected]>
1 parent cf3edb9 commit ed186e5

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

cmd/yardstick-client/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ The client connects to MCP servers using various transport mechanisms and allows
3131
## Environment Variables
3232

3333
Configuration can also be set via environment variables:
34-
- `TRANSPORT`: Override transport type
35-
- `ADDRESS`: Override server address
34+
- `MCP_TRANSPORT`: Override transport type
35+
- `ADDRESS`: Override server address
3636
- `PORT`: Override server port
3737
- `COMMAND`: Override command for stdio transport
3838

@@ -101,7 +101,7 @@ Call a specific tool with provided JSON arguments:
101101

102102
### Using environment variables
103103
```bash
104-
export TRANSPORT=sse
104+
export MCP_TRANSPORT=sse
105105
export ADDRESS=remote.example.com
106106
export PORT=3000
107107
./client -action=list-resources

cmd/yardstick-client/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ func parseConfig() Config {
211211
}
212212

213213
// Use environment variables if provided
214-
if t, ok := os.LookupEnv("TRANSPORT"); ok {
214+
if t, ok := os.LookupEnv("MCP_TRANSPORT"); ok {
215215
config.Transport = t
216216
}
217217
if a, ok := os.LookupEnv("ADDRESS"); ok {

cmd/yardstick-client/main_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func TestConfig_ParseConfig(t *testing.T) {
3939

4040
// Save original env vars
4141
originalEnvVars := map[string]string{}
42-
envVars := []string{"TRANSPORT", "ADDRESS", "PORT", "COMMAND"}
42+
envVars := []string{"MCP_TRANSPORT", "ADDRESS", "PORT", "COMMAND"}
4343
for _, env := range envVars {
4444
if val, exists := os.LookupEnv(env); exists {
4545
originalEnvVars[env] = val
@@ -59,20 +59,20 @@ func TestConfig_ParseConfig(t *testing.T) {
5959
// Test environment variable override
6060
t.Run("environment variables", func(t *testing.T) {
6161
// Set test env vars
62-
os.Setenv("TRANSPORT", "streamable-http")
62+
os.Setenv("MCP_TRANSPORT", "streamable-http")
6363
os.Setenv("ADDRESS", "remote.example.com")
6464
os.Setenv("PORT", "3000")
6565
os.Setenv("COMMAND", "test-command")
6666

6767
defer func() {
68-
os.Unsetenv("TRANSPORT")
68+
os.Unsetenv("MCP_TRANSPORT")
6969
os.Unsetenv("ADDRESS")
7070
os.Unsetenv("PORT")
7171
os.Unsetenv("COMMAND")
7272
}()
7373

7474
// Test that env vars would be read (we can't call parseConfig due to flag redefinition)
75-
transport, transportExists := os.LookupEnv("TRANSPORT")
75+
transport, transportExists := os.LookupEnv("MCP_TRANSPORT")
7676
assert.True(t, transportExists)
7777
assert.Equal(t, "streamable-http", transport)
7878

cmd/yardstick-server/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,12 @@ docker run -it ghcr.io/stackloklabs/yardstick/server
6464

6565
**SSE Transport:**
6666
```bash
67-
docker run -p 8080:8080 -e TRANSPORT=sse -e PORT=8080 ghcr.io/stackloklabs/yardstick/server
67+
docker run -p 8080:8080 -e MCP_TRANSPORT=sse -e PORT=8080 ghcr.io/stackloklabs/yardstick/server
6868
```
6969

7070
**Streamable HTTP Transport:**
7171
```bash
72-
docker run -p 8080:8080 -e TRANSPORT=streamable-http -e PORT=8080 ghcr.io/stackloklabs/yardstick/server
72+
docker run -p 8080:8080 -e MCP_TRANSPORT=streamable-http -e PORT=8080 ghcr.io/stackloklabs/yardstick/server
7373
```
7474

7575
## Tools

cmd/yardstick-server/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ func parseConfig() {
142142
flag.Parse()
143143

144144
// Use environment variables if provided, otherwise use flag values
145-
if t, ok := os.LookupEnv("TRANSPORT"); ok {
145+
if t, ok := os.LookupEnv("MCP_TRANSPORT"); ok {
146146
transport = t
147147
}
148148
if p, ok := os.LookupEnv("PORT"); ok {

0 commit comments

Comments
 (0)