Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Cloud Build build config file #154

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mans0954
Copy link
Contributor

Add a cloudbuild.yaml file for building the stackdriver-prometheus-sidecar binary and docker image with Google's Cloud Build service.

@mans0954 mans0954 changed the title Csh cloudbuilder Add Google Cloud Build build config file Aug 27, 2019
@davidbtucker davidbtucker self-requested a review August 29, 2019 20:58
@davidbtucker
Copy link
Contributor

Hi Christopher. Can you explain the motivation behind this PR? Our team doesn't use Cloud Build for this particular project. Thanks.

@mans0954
Copy link
Contributor Author

mans0954 commented Sep 4, 2019

Dear David,

Unfortunately we're finding it necessary to build our own fork of stackdriver-prometheus-sidecar, as the official builds have a couple of issues which are show-stoppers for us. Having composed a cloudbuild.yaml file for my employer's use, we thought we'd offer it upstream in case it was of use to anyone else in the same predicament.

Christopher

Copy link
Contributor

@davidbtucker davidbtucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two minor changes.

cloudbuild.yaml Outdated Show resolved Hide resolved
cloudbuild.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants