-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Cloud Build build config file #154
base: master
Are you sure you want to change the base?
Conversation
Hi Christopher. Can you explain the motivation behind this PR? Our team doesn't use Cloud Build for this particular project. Thanks. |
Dear David, Unfortunately we're finding it necessary to build our own fork of stackdriver-prometheus-sidecar, as the official builds have a couple of issues which are show-stoppers for us. Having composed a cloudbuild.yaml file for my employer's use, we thought we'd offer it upstream in case it was of use to anyone else in the same predicament. Christopher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two minor changes.
Add a
cloudbuild.yaml
file for building the stackdriver-prometheus-sidecar binary and docker image with Google's Cloud Build service.