Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: oracle text includes string not working as expected #50

Open
djpiper28 opened this issue Dec 29, 2024 · 2 comments
Open

[Bug]: oracle text includes string not working as expected #50

djpiper28 opened this issue Dec 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@djpiper28
Copy link
Collaborator

What went wrong:

o:"target creature gains protection" does not provide cards with that in the oracle text, however o:/.*target creature gains protection.*/ does.

Expected behavior:

o:/.*target creature gains protection.*/ and o:"target creature gains protection" should provide the same output.

@djpiper28 djpiper28 added the bug Something isn't working label Dec 29, 2024
@djpiper28 djpiper28 changed the title [Bug]: [Bug]: oracle text includes string not working as expected Dec 29, 2024
@djpiper28
Copy link
Collaborator Author

Also occurs with the name:"goblin motivator" which should have the same output as goblin motivator

@djpiper28
Copy link
Collaborator Author

Two cases:

  1. o:<WORD>
    i.e: o:opt, the levenshtein difference should used on output of the trie and all cards with greater than 80% matching should be added to the output

  2. o:<STRING>
    i.e: opt:"goblin motivator", a lookup for the exact string goblin motivator (monte carlo string lookup) should be done after normalisation. Normalisation being turning everything to lowercase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant