Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support all tier 2 targets and check in CI #84

Open
2 tasks
SpriteOvO opened this issue Feb 3, 2025 · 0 comments
Open
2 tasks

[Feature Request] Support all tier 2 targets and check in CI #84

SpriteOvO opened this issue Feb 3, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@SpriteOvO
Copy link
Owner

SpriteOvO commented Feb 3, 2025

As of this issue being opened, we have received 2 reports (#36 #82) of the compile error due to platform-specific code.

Rust has a target tier policy, in Rust doc, the definition of tier 2 is

Tier 2 targets can be thought of as "guaranteed to build". The Rust project builds official binary releases of the standard library (or, in some cases, only the core library) for each tier 2 target, and automated builds ensure that each tier 2 target can be used as build target after each change. Automated tests are not always run so it's not guaranteed to produce a working build, but tier 2 targets often work to quite a good degree and patches are always welcome!

IMO, tier 2 covers most common targets. It would be nice if we apply the same "guaranteed to build" policy for spdlog-rs, so that we can support as many as possible targets in advance, without waiting for bug reports from users.

TODO

  • Add a CI to check all the compilation of all tier 2 targets.
    • How to get a list of all tier 2 targets?
      • rustc +nightly --print all-target-specs-json -Z unstable-options
  • Make platform-specific code to support these all platforms.
@SpriteOvO SpriteOvO added the enhancement New feature or request label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant