From 94181c811c812b5ea26ea96750b2443f81dcae7e Mon Sep 17 00:00:00 2001 From: Hooni07 Date: Sun, 10 Mar 2024 15:46:24 +0900 Subject: [PATCH 1/2] =?UTF-8?q?Refactor:=20=EB=B6=88=ED=95=84=EC=9A=94?= =?UTF-8?q?=ED=95=9C=20console.log=20=EC=BD=94=EB=93=9C=20=EC=A0=9C?= =?UTF-8?q?=EA=B1=B0=20=EB=B0=8F=20Error=20=EB=B0=A9=EC=8B=9D=20=ED=86=B5?= =?UTF-8?q?=EC=9D=BC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/components/EditMessage/EditMessage.jsx | 6 ++++-- src/components/WritingMessage/WritingForm.jsx | 1 - src/components/WritingMessage/WritingMessage.jsx | 2 +- src/components/list/RecipientCard.jsx | 3 ++- src/components/post/subheader/EmojiDropDown.jsx | 2 +- src/pages/List.js | 2 +- src/pages/PostId.jsx | 2 +- 7 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/components/EditMessage/EditMessage.jsx b/src/components/EditMessage/EditMessage.jsx index 947f491..94db2b6 100644 --- a/src/components/EditMessage/EditMessage.jsx +++ b/src/components/EditMessage/EditMessage.jsx @@ -12,13 +12,15 @@ const FormContainer = styled.div` function EditMessage() { const [buttonDisabled, setButtonDisabled] = useState(true); - console.log(buttonDisabled); return (
- setButtonDisabled(isContent)} /> + setButtonDisabled(isContent)} + disabled={buttonDisabled} + />
); diff --git a/src/components/WritingMessage/WritingForm.jsx b/src/components/WritingMessage/WritingForm.jsx index a7be79b..2500ad9 100644 --- a/src/components/WritingMessage/WritingForm.jsx +++ b/src/components/WritingMessage/WritingForm.jsx @@ -273,7 +273,6 @@ function WritingForm({ isBtnDisabled }) { content: contents, font: fonts, }; - console.log(data); const response = await submitMessagePost(recipientID, data); return response.recipientId; }} diff --git a/src/components/WritingMessage/WritingMessage.jsx b/src/components/WritingMessage/WritingMessage.jsx index c134fd1..6844b20 100644 --- a/src/components/WritingMessage/WritingMessage.jsx +++ b/src/components/WritingMessage/WritingMessage.jsx @@ -12,7 +12,6 @@ const FormContainer = styled.div` function WritingMessage() { const [buttonDisabled, setButtonDisabled] = useState(true); - console.log(buttonDisabled); return (
@@ -20,6 +19,7 @@ function WritingMessage() { setButtonDisabled(isContent)} + disabled={buttonDisabled} />
diff --git a/src/components/list/RecipientCard.jsx b/src/components/list/RecipientCard.jsx index f2d1222..ac89482 100644 --- a/src/components/list/RecipientCard.jsx +++ b/src/components/list/RecipientCard.jsx @@ -1,5 +1,6 @@ import React, { useState, useEffect } from 'react'; import { useNavigate } from 'react-router-dom'; + import styled, { css } from 'styled-components'; import WrittenByIcons from '../post/subheader/WrittenByIcons'; import { getAllMessages } from '../../api/GetApi'; @@ -22,7 +23,7 @@ function RecipientCard({ recipient }) { const result = await getAllMessages(recipient.id); setMessages(result.results); } catch (error) { - console.error('메시지를 불러오는데 실패했습니다:', error); + throw new Error('메시지를 불러오는데 실패했습니다:', error); } }; diff --git a/src/components/post/subheader/EmojiDropDown.jsx b/src/components/post/subheader/EmojiDropDown.jsx index 0b804f6..947b375 100644 --- a/src/components/post/subheader/EmojiDropDown.jsx +++ b/src/components/post/subheader/EmojiDropDown.jsx @@ -127,7 +127,7 @@ function EmojiDropDown() { })); setBadges(data); } catch (error) { - console.error('Failed to fetch data', error); + throw new Error('Failed to fetch data', error); } }; diff --git a/src/pages/List.js b/src/pages/List.js index e6208e5..a8e1e34 100644 --- a/src/pages/List.js +++ b/src/pages/List.js @@ -34,7 +34,7 @@ function List() { setPopularRecipients(sortedByPopularity); setRecentRecipients(sortedByRecent); } catch (error) { - console.error('롤링페이퍼를 불러오지 못했습니다.', error); + throw new Error('롤링페이퍼를 불러오지 못했습니다.', error); } }; diff --git a/src/pages/PostId.jsx b/src/pages/PostId.jsx index 937a289..f30ea59 100644 --- a/src/pages/PostId.jsx +++ b/src/pages/PostId.jsx @@ -71,7 +71,7 @@ function PostId() { const result = await getRecipientData(id); setData(result); } catch (error) { - // console.error(error); + throw new Error('데이터를 불러오지 못했습니다.', error); } }; From 7a677d02c3c1e7cd78a1f2e6ccff47795dc21d3f Mon Sep 17 00:00:00 2001 From: Hooni07 Date: Sun, 10 Mar 2024 15:49:57 +0900 Subject: [PATCH 2/2] =?UTF-8?q?Docs:=20README=20=ED=8C=8C=EC=9D=BC=20?= =?UTF-8?q?=EC=B6=94=EA=B0=80=20=EB=82=B4=EC=9A=A9=20=EC=9E=91=EC=84=B1?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 1edf347..9e032f5 100644 --- a/README.md +++ b/README.md @@ -88,6 +88,7 @@ URL: https://sp4-team16-rolling.netlify.app - 단위(px->rem) refactoring 진행 - Size, Color, Font, Option 등 상수화 작업 및 적용 - 일부 수치조정 과정에서 발생하는 디자인 오류 수정 및 개선 + - 코드 스타일링: 불필요한 코드 제거 및 error 반환 방식 통일 - 팀 repository 생성 및 issues, label 등 초기 세팅 설정 - issues 항목 설정 - label 카테고리 생성