Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message should be send when client send invalid UUID field #18

Open
kestivvi opened this issue Mar 21, 2023 · 0 comments
Open

Error message should be send when client send invalid UUID field #18

kestivvi opened this issue Mar 21, 2023 · 0 comments
Labels
difficulty: 🙂🙂 Below average task scope: 🛠️ it's job for developers type: bug 🪰 issue: reporting a bug

Comments

@kestivvi
Copy link
Member

kestivvi commented Mar 21, 2023

For example JoinRoom reaction is handling invalid UUID sent by the client, but just that in dataclass of this reaction, precisely in the RoomDTO for example there is UUID field, this is checked automatically for valid UUID by the JsonParser in the onMessage method in the WebSocketSplendorServer class. So checking for valid UUID is redundant in the reactions.

But for some reason, error response is not being sent by the server when this happen. There must be something wrong in the WebSocketSplendorServer class in its onMessage method.

This bug occures on current commit (faea176) when client send this request:

{
   "messageContextId":"80bdc250-5365-4caf-8dd9-a33e709a0116",
   "type":"CREATE_ROOM",
   "data":{
      "userDTO":{
         "uuid":"tajny",
         "name":"James"
      },
      "roomDTO":{
         "name":"TajnyPokoj",
         "password":"kjashjkasd"
      }
   }
}
@kestivvi kestivvi added type: bug 🪰 issue: reporting a bug effort: 8 and removed effort: 8 labels Mar 21, 2023
@kestivvi kestivvi added difficulty: 🙃🙃🙃 Above average task scope: 🛠️ it's job for developers difficulty: 🙂🙂 Below average task and removed difficulty: 🙃🙃🙃 Above average task labels Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 🙂🙂 Below average task scope: 🛠️ it's job for developers type: bug 🪰 issue: reporting a bug
Projects
None yet
Development

No branches or pull requests

1 participant