Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SSL #12

Open
justinhj opened this issue Nov 11, 2017 · 13 comments
Open

Support for SSL #12

justinhj opened this issue Nov 11, 2017 · 13 comments

Comments

@justinhj
Copy link

Hi. I was hoping to use the library against cloudkarafka but it uses an SSL connection. It looks like the library does not support that. Is there any plan to?

https://www.cloudkarafka.com/docs-java.html

@pchlupacek
Copy link
Member

@justinhj there should not be big deal to add SSL support. In fact currently the SSL support for fs2 is pending review, once that will be done, it will be just question to plug it here and testing.
I would expect this to be available in few weeks.

@justinhj
Copy link
Author

justinhj commented Nov 12, 2017 via email

@ranjanibrickx
Copy link

We are also looking to use SSL connection with kafka, could you please let us know if there is any update on this?
Thanks :)

@AdamChlupacek
Copy link
Member

@ranjanibrickx hey there, with the release of fs2-crypto, this should be really easy to PR, I can get it together over the weekend if that is soon enough for you?

@ranjanibrickx
Copy link

@AdamChlupacek - thank you so much for the response! That's great news - in the next week or so would be awesome! :) Looking forward to it.

@AdamChlupacek
Copy link
Member

@ranjanibrickx hey, so in theory I have a working version of this. Dont really have any test for this tho :/ Would you happen to know about an easy way (preferably docker) how to get kafka running with a SSL turned on on it? I dont see any other way than setting it all up manually, which is just bothersome.

The only kafka docker image I know of is https://github.com/wurstmeister/kafka-docker and that does not seem to support SSL

@justinhj
Copy link
Author

justinhj commented Apr 17, 2018 via email

@AdamChlupacek
Copy link
Member

@justinhj Oh, yeah, thanks for the link, I think I now know to integrate the SSL enabled kafka into our tests. Will get it done tonight.

@AdamChlupacek
Copy link
Member

@justinhj @ranjanibrickx So I have a version of something that in theory should work on feature/ssl at the moment the kafka broker and client handshake successfully but afterwards kafka refuses to unwrap any data from us. If anyone wanna get a stab at it be free to do so. (the fs2-crypto snapshot there is just a snapshot with added one fix from 0.1 brach, it should generally work with the current 0.2.0 fs2-crypto).

@justinhj
Copy link
Author

justinhj commented Apr 19, 2018 via email

@felixmulder
Copy link

If there's anything I can do to help get this in, let me know. I'd love to see this happen as we're wanting to abandon the Apache client :)

@AdamChlupacek
Copy link
Member

hey @felixmulder You can checkout the branch I mentioned in previous comment. Currently it is stuck at kafka replying something along: "Message cannot be parsed" inside of SSL error. It happens right after handshake at the first point kafka is receiving application data. I suspect the message format is a bit different for SSL connection, but had no luck in finding how different it is. Sadly dont have any time to spend on this at the moment.

@felixmulder
Copy link

@AdamChlupacek - looks to me like Kafka isn't responding to the handshake. The unwrap method in TLSEngine is never called, and as such the Wrap#handshakeComplete function is never called - thus it is locked in waiting for the next part of the handshake.

If it's as you say - how can I see the handshake from Kafka's side? Are you attaching yourself to the kafka docker container?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants