Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attack stop #684

Open
youhide opened this issue May 20, 2021 · 9 comments · May be fixed by #1200
Open

Attack stop #684

youhide opened this issue May 20, 2021 · 9 comments · May be fixed by #1200

Comments

@youhide
Copy link

youhide commented May 20, 2021

if you attack and cast spell the fight is canceled for your char, the other stay on fight
the both stays on war mode
tested in pvp

@drk84
Copy link
Member

drk84 commented May 21, 2021

When you cast something your current action is cancelled and you have to attack again, it's the normal behaviour.
If the opponent hit you you will fight back

My current action is wrestling
I cast spell my current action is now magery

@Soulless-1
Copy link
Contributor

i have found instances where you do not hit them back but appear to be in combat, even when you get hit.

@youhide
Copy link
Author

youhide commented Jun 20, 2021

im using this for workaround, maybe a better solution on core is the way...

ON=@SpellSelect
if ( == Wrestling) || ( == Swordsmanship) || ( == Macefighting) || ( == Fencing) || ( == Archery)
ctag.lastaction=
//serv.log write lastaction for , action <ctag.lastaction>
endif
ON=@SpellFail
if (<ctag0.lastaction>)
//serv.log magery casted, take back to lastaction <ctag.lastaction>
timerfms 10, action=<ctag.lastaction>
ctag.lastaction
endif
ON=@SpellSuccess
if (<ctag0.lastaction>)
//serv.log magery casted, take back to lastaction <ctag.lastaction>
timerfms 10, action=<ctag.lastaction>
ctag.lastaction
endif

@cbnolok
Copy link
Contributor

cbnolok commented Sep 4, 2021

Afair i solved that as a player using the attacklast macro, i can be wrong.
Dunno if it's the case to add an OptionFlag for this

@a1exp
Copy link

a1exp commented Oct 28, 2021

@drk84 @cbnolok

Guys, common.. This is a huge problem for PvP. Behaviour changed comparing to 56b.
On 56b attack never canceled when you casted spell on self. It interrupted but continued after spell cast.

Moreover attacklast macro does not help. So PvP is broken, you have to tab and attack again.

This needs to be fixed.

This is 56b behaviour, char continues to attack automatically.

bandicam.2021-10-28.04-38-27-774.mp4

@drk84
Copy link
Member

drk84 commented Oct 28, 2021

LastATtack macro works here with client 7.0.20.
I attack the character, then cast magic arrow, i press the attacklast macro and i swing again

@a1exp
Copy link

a1exp commented Oct 28, 2021

@drk84
I tested on 2.0.3, 5.0.6 and latest version of Orion, same behaviour. Also double checked with default script pack to make sure that's not my scripts problem. You can see on the video below.

  1. I attack 1st dummy
  2. Then I cast Magic Arrow to the second dummy
  3. Then I press "attacklast" client macro and as you can notice second dummy becomes hightlighted.

So attacklasts's target swtiched from 1st to 2nd dummy after spell cast.

attack_cast_bug.mp4

@a1exp
Copy link

a1exp commented Oct 28, 2021

Another video, same scenario, but after I press "attacklast" and just come to the second dummy, my char automatically starts attacking it.

Somehow spell cast switched uid of char which should be attacked on "attacklast"

bandicam.2021-10-28.21-00-40-279.mp4

@Tolokio
Copy link
Contributor

Tolokio commented Oct 20, 2022

We could see how it is done at sphere56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants