Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tra-files inside the mod should not be changed / deleted upon installation / deinstallation #3

Open
Gitjas opened this issue Jun 12, 2022 · 2 comments

Comments

@Gitjas
Copy link
Contributor

Gitjas commented Jun 12, 2022

-The mod creates a weidu-external/lang/ subfolder and copies the tra files there. But:

  1. the transformated utf8-files and the tagged tra-files etc. are still inside the mod lang/%LANGUAGE% folder, not the weidu-external one.
  2. if the mod is deinstalled or does not install due to an install error, the tra files inside the mod are gone, the language folder is empty afterwards.
    I tried this with v2.0.1, Russian version.
    to 1: Install option 1 of v 2.0.1 and look into the lang/%LANGUAGE% folder.
    to 2: Deinstall the mod and look into the lang/%LANGUAGE% folder. Copy a new v2.0.1 into your game folder and install option 2 of v 2.0.1, Russian version. Chose not to install the mod after the error message and look into the lang/russian folder.

Expected behavior:

  1. the tra-files in the mod folder should not be touched/changed while the mod is installed.
  2. the tra-files should not be gone after the mod is deinstalled/did not install.
@Gitjas
Copy link
Contributor Author

Gitjas commented Jun 12, 2022

I cannot reproduce point 2: tra files are now back inside the lang/%LANGUAGE% folder of the mod after normal deinstallation (tried with updated interim version with fixed Russian install).
Point 1 stands.

@GwendolyneFreddy
Copy link
Collaborator

Using WeiDU 247 installer, this workaround was not perfect...
I must re-write all the tra install process with WeiDU 249 new feature that allows variable in AUTO_TRA command, as I did with Expended Thief Stronghold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants