Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hey @Vukiz, thanks for the PR! There're 2 things we need to address before merging: #208

Closed
alikia19 opened this issue Oct 28, 2021 · 0 comments
Closed

Hey @Vukiz, thanks for the PR! There're 2 things we need to address before merging: #208

alikia19 opened this issue Oct 28, 2021 · 0 comments

Comments

@alikia19
Copy link

Hey @Vukiz, thanks for the PR! There're 2 things we need to address before merging:

  • Can you fix the broken unit test ion iOS: Native/iOS/LunarConsole/LunarConsoleTests/LUActionRegistryFilterTest.swift:54:7: Type 'LUActionRegistryFilterTest' does not conform to protocol 'LUActionRegistryFilterDelegate'?
  • Can you sign the Individual Contributor License Agreement (CLA)?

Originally posted by @weeeBox in #195 (comment)
@alikia19 alikia19 closed this as completed Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alikia19