JRE Provisioning: Add ITs for parameter propagation to end step (#2068)

Author: gregory-paidis-sonarsource

its/src/test/java/com/sonar/it/scanner/msbuild/sonarcloud/JreProvisioningTest.java

@@ -134,4 +134,40 @@ void jreProvisioning_endToEnd_cacheHit_reusesJre() throws IOException {
       "JreResolver: Cache miss",
       "Starting the Java Runtime Environment download.");
   }
+
+  @Test
+  void jreProvisioning_endToEnd_parameters_propagated() throws IOException {
+    var projectDir = TestUtils.projectDir(basePath, PROJECT_NAME);
+
+    SonarCloudUtils.runBeginStep(
+      projectDir,
+      SONARCLOUD_PROJECT_KEY,
+      new StreamConsumer.Pipe(new StringWriter()),
+      "/d:sonar.scanner.os=windows",
+      "/d:sonar.scanner.arch=x64",
+      "/d:sonar.scanner.skipJreProvisioning=true",
+      "/d:sonar.scanner.connectTimeout=42",
+      "/d:sonar.scanner.socketTimeout=100",
+      "/d:sonar.scanner.responseTimeout=500",
+      "/d:sonar.userHome=" + projectDir.toAbsolutePath());
+
+    SonarCloudUtils.runBuild(projectDir);
+
+    var logWriter = new StringWriter();
+    StreamConsumer.Pipe logConsumer = new StreamConsumer.Pipe(logWriter);
+    SonarCloudUtils.runEndStep(projectDir, logConsumer);
+
+    var logs = logWriter.toString();
+    assertThat(logs).contains(
+      "Dumping content of sonar-project.properties",
+      "sonar.scanner.sonarcloudUrl=" + Constants.SONARCLOUD_URL,
+      "sonar.scanner.apiBaseUrl=" + Constants.SONARCLOUD_API_URL,
+      "sonar.scanner.os=windows",
+      "sonar.scanner.arch=x64",
+      "sonar.scanner.skipJreProvisioning=true",
+      "sonar.scanner.connectTimeout=42",
+      "sonar.scanner.socketTimeout=100",
+      "sonar.scanner.responseTimeout=500",
+      "sonar.userHome=" + projectDir.toAbsolutePath().toString().replace("\\", "\\\\"));
+  }
 }

its/src/test/java/com/sonar/it/scanner/msbuild/sonarcloud/SonarCloudUtils.java

@@ -80,7 +80,7 @@ public static void runBeginStep(Path projectDir, String projectKey, StreamConsum
     assertThat(beginResult).isZero();
   }
 
-  private static void runEndStep(Path projectDir, StreamConsumer.Pipe logConsumer) {
+  public static void runEndStep(Path projectDir, StreamConsumer.Pipe logConsumer) {
     var endCommand = Command.create(new File(Constants.SCANNER_PATH).getAbsolutePath())
       .setDirectory(projectDir.toFile())
       .addArgument("end")