Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOL-89741] Solace-binder not support instrument in SpringBoot 3.x && Spring Cloud 2022.x #219

Open
desertTown opened this issue Apr 28, 2023 · 4 comments
Labels
enhancement New feature or request tracked Internally tracked by Solace's internal issue tracking system

Comments

@desertTown
Copy link

Hi Solace support,

we found that there no related span info send out to solace while we use SpringBoot version 3.x,
and SpringCloud Support Marcin Grzehszczak said That's a missing instrumentation in the solace binder. they have changed the way SC function gets instrumented. Function now instruments only the function itself and it's up to the binders to instrument the edges. If you're using Rabbit or Kafka binder these would be the instrumentations in Rabbit or Kafka - those should be automatically turned on by Spring Cloud Stream.

can I confirm if solace-binder support instrument in SpringBoot 3.x?

Thanks

@Nephery
Copy link
Collaborator

Nephery commented May 18, 2023

#227 added support for Spring Boot 3.x & Spring Cloud 2022.x. Does that fix this?

@Nephery Nephery added the question Further information is requested label May 18, 2023
@MikeR13
Copy link

MikeR13 commented Jul 6, 2023

I think what @desertTown means is something like this: https://github.com/micrometer-metrics/micrometer-samples/blob/main/kafka-producer/src/main/java/com/example/micrometer/ManualConfiguration.java#L20C28-L20C49
Does the actual Solace Binder support this or not?
We have done experiments with micrometer-tracing-bridge-otel and micrometer-tracing-bridge-brave. The tracing information is not propagated with either of them, so no headers are set in the messages.
Did we miss something?

@Nephery Nephery changed the title Solace-binder not support instrument in SpringBoot 3.x && Spring Cloud 2022.x [SOL-89741] Solace-binder not support instrument in SpringBoot 3.x && Spring Cloud 2022.x Jul 6, 2023
@Nephery Nephery added enhancement New feature or request tracked Internally tracked by Solace's internal issue tracking system and removed question Further information is requested labels Jul 6, 2023
@dbruegger
Copy link

A proper solution would be to instrument Solace Spring Cloud Binder using the Micrometer Observation API. This means to run a Micrometer Observation with a ReceiverContext around the input message listener and Micrometer Observation with a SenderContext around the sending of the message over the message producer. With this in place, the preconfigured DefaultTracingObservationHandler automatically propagates the tracing context through the Solace messages.

For example, the following commit implements the Micrometer observability instrumentation in spring-rabbit (which is at the base of spring-cloud-stream-binder-rabbit): Listener Observability Initial Commit.

@desertTown
Copy link
Author

#227 added support for Spring Boot 3.x & Spring Cloud 2022.x. Does that fix this?
Hi @Nephery
The issue has not been fixed as of the latest version of SpringBoot 3.x and Cloud. Do you have any plans to address it and release a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tracked Internally tracked by Solace's internal issue tracking system
Projects
None yet
Development

No branches or pull requests

4 participants