-
Notifications
You must be signed in to change notification settings - Fork 63
feat(DATAGO-117907): Show created artifacts in the workflow diagram #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RZuchniak
wants to merge
11
commits into
main
Choose a base branch
from
robert/artifact-event
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c638144
feat: initial attempt
RZuchniak 8a0e659
fix: typescript errors
RZuchniak 9b5cf56
feat: artifacts created from fenced blocks
RZuchniak 6fb3e42
fix: switch to serperate A2A event
RZuchniak 878efba
fix revert some code
RZuchniak 402c9c4
fix: switch back to old signal
RZuchniak d669f44
fix: remove old code
RZuchniak 306c310
chore: remove old tests
RZuchniak 909827b
chore: move test
RZuchniak b90a77f
fix: node position calculations
RZuchniak 9df3f1e
fix: add test for llm generated artifacts
RZuchniak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
...ebui/frontend/src/lib/components/activities/FlowChart/customNodes/GenericArtifactNode.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import React from "react"; | ||
|
|
||
| import { Handle, Position, type NodeProps, type Node } from "@xyflow/react"; | ||
|
|
||
| import type { GenericNodeData } from "./GenericAgentNode"; | ||
|
|
||
| export type ArtifactNodeType = Node<GenericNodeData>; | ||
|
|
||
| const ArtifactNode: React.FC<NodeProps<ArtifactNodeType>> = ({ data, id }) => { | ||
| return ( | ||
| <div | ||
| className="cursor-pointer rounded-lg border-2 border-purple-600 bg-white px-3 py-3 text-gray-800 shadow-md transition-all duration-200 ease-in-out hover:scale-105 hover:shadow-xl dark:border-purple-400 dark:bg-gray-800 dark:text-gray-200" | ||
| style={{ minWidth: "120px", textAlign: "center" }} | ||
| > | ||
| <Handle type="target" position={Position.Left} id={`${id}-artifact-left-input`} className="!bg-purple-500" isConnectable={true} /> | ||
| <div className="flex flex-col items-center justify-center gap-1"> | ||
| <div className="flex items-center justify-center"> | ||
| <div className="mr-2 h-2 w-2 rounded-full bg-purple-500" /> | ||
| <div className="text-md">{data.label}</div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ArtifactNode; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The artifact node creation uses a generic "Artifact" label instead of including the actual artifact name. This makes it difficult to distinguish between multiple artifacts in the workflow diagram.
Consider updating the label to include the artifact name:
This would make the diagram more informative and easier to understand.