Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate iBeacon::data[] #2

Open
SodaqMoja opened this issue Feb 11, 2017 · 0 comments
Open

Eliminate iBeacon::data[] #2

SodaqMoja opened this issue Feb 11, 2017 · 0 comments

Comments

@SodaqMoja
Copy link
Owner

This char buffer is only used to build up an iBeacon frame and then passed on to startImmediateBeacon.
Having the char array declared in the class reserves 50 bytes for the whole lifetime of the program. That's a waste.

I'd propose to remove it and to declare a (stack) char buffer in iBeacon::begin().

The size of the buffer (IBEACON_FRAME_SIZE) should be done with # ifndef / # define / # endif, so that it can be overruled if there is a need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant