Skip to content

Commit bf50e35

Browse files
leliaclaude
andcommitted
Drop ticket references from code comments, workflows, and changelog
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
1 parent d0465a3 commit bf50e35

6 files changed

Lines changed: 13 additions & 13 deletions

File tree

.github/workflows/e2e-test.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ jobs:
4747
validate: tests/e2e/validate-reachability.sh
4848
setup-node: "true"
4949
# The tier-1 reachability backend intermittently returns empty
50-
# results while the CLI reports success (ENG-5093). The probe
51-
# exits 0 when the facts file has alerted components; anything
52-
# else is retried before validation fails the job.
50+
# results while the CLI reports success. The probe exits 0 when
51+
# the facts file has alerted components; anything else is
52+
# retried before validation fails the job.
5353
retry-probe: bash tests/e2e/reach-facts-probe.sh tests/e2e/fixtures/simple-npm
5454

5555
- name: gitlab
@@ -123,7 +123,7 @@ jobs:
123123
echo "::warning title=e2e-${{ matrix.name }} incomplete results::output still fails the completeness probe after ${max_attempts} attempts; letting validation fail the job"
124124
break
125125
fi
126-
echo "::warning title=e2e-${{ matrix.name }} transient retry::attempt ${attempt} failed the completeness probe (suspected backend transient, see ENG-5093); retrying"
126+
echo "::warning title=e2e-${{ matrix.name }} transient retry::attempt ${attempt} failed the completeness probe (suspected backend transient); retrying"
127127
echo "e2e-${{ matrix.name }}: retry after attempt ${attempt} — completeness probe failed (suspected transient)" >> "$GITHUB_STEP_SUMMARY"
128128
attempt=$((attempt+1))
129129
sleep 30

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
intermittent `Connection reset by peer` failures on the final comparison
1313
step when scans take several minutes to compare and network middleboxes
1414
(e.g. Azure NAT gateways, which default to a 4-minute TCP idle timeout)
15-
reap the idle connection (CE-354).
15+
reap the idle connection.
1616
- Duplicate scan pairs are resolved after an HTTP 409 and then polled through
1717
the same cached endpoint. This avoids automatically following the API's 302
1818
duplicate redirect with an uncached, potentially long-lived GET request.

socketsecurity/core/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
# single HTTP connection open, fully idle, while the backend computes the diff; network
9797
# middleboxes with TCP idle timeouts (notably Azure NAT gateways, which default to
9898
# 4 minutes) kill that connection with a RST, surfacing as an intermittent
99-
# ConnectionResetError on large scans (CE-354). The diff-scans flow instead creates a
99+
# ConnectionResetError on large scans. The diff-scans flow instead creates a
100100
# diff-scan resource and polls its cached endpoint with short bounded requests: the API
101101
# answers 202 while the comparison is still computing and 200 with the result once it is
102102
# ready, so no connection is ever idle long enough to be reaped.
@@ -1333,8 +1333,8 @@ def get_diff_scan_artifacts(
13331333
``GET /orgs/{org}/diff-scans/{id}?cached=true`` until the API returns the
13341334
computed comparison (200) instead of a processing status (202). Unlike the
13351335
legacy ``fullscans.stream_diff`` call, no request is ever left idle while
1336-
the backend computes, so the comparison survives network idle timeouts
1337-
(CE-354). See the DIFF_SCAN_POLL_* constants for the polling policy.
1336+
the backend computes, so the comparison survives network idle timeouts.
1337+
See the DIFF_SCAN_POLL_* constants for the polling policy.
13381338
13391339
Requires an org token with the ``diff-scans:create``, ``diff-scans:list``
13401340
and ``full-scans:list`` scopes; callers are expected to catch failures and
@@ -1394,7 +1394,7 @@ def get_diff_scan_artifacts(
13941394
# ready). The API ignores omit_license_details when cached=true - cached
13951395
# results always embed license details - so there is no lean-response
13961396
# option on this path (unlike stream_diff with
1397-
# include_license_details=false, the CE-224 mitigation). If that extra
1397+
# include_license_details=false, the lean-payload mitigation). If that extra
13981398
# payload ever gets a response truncated on a huge dependency tree,
13991399
# response.json() fails and the caller falls back to the legacy
14001400
# streaming comparison, which still requests the lean payload.

tests/core/test_diff_scan_polling.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
"""Tests for the diff-scans polling scan comparison (CE-354).
1+
"""Tests for the diff-scans polling scan comparison.
22
33
The comparison must never hold an idle connection open: it creates a diff-scan
44
resource and polls the cached endpoint (202 while processing, 200 when ready),

tests/core/test_sdk_methods.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ def test_get_added_and_removed_packages(core):
228228

229229
# Verify SDK was called correctly: the comparison goes through the diff-scans
230230
# endpoints (create + poll) rather than the legacy streaming diff, so no
231-
# connection is left idle while the backend computes (CE-354).
231+
# connection is left idle while the backend computes.
232232
create_args = core.sdk.diffscans.create_from_ids.call_args
233233
assert create_args[0][0] == core.config.org_slug
234234
create_params = create_args[0][1]

tests/e2e/reach-facts-probe.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
#
44
# Used by the e2e workflow's retry-probe hook: a --reach run against the
55
# known-vulnerable fixture that reports success but yields no alerted
6-
# components is the signature of a transient tier-1 backend failure
7-
# (ENG-5093), so the run is worth repeating before validation fails the job.
6+
# components is the signature of a transient tier-1 backend failure,
7+
# so the run is worth repeating before validation fails the job.
88
set -euo pipefail
99

1010
TARGET="${1:?usage: reach-facts-probe.sh <target-path>}"

0 commit comments

Comments
 (0)