Commit 14abc4e
committed
fix(models): correct --all flag logic to build both models
Fix bug where --all flag only built CodeT5, not MiniLM.
Issue: The BUILD_MINILM condition excluded --all from the logic:
BUILD_MINILM = args.includes('--minilm') || (\!args.includes('--codet5') && \!args.includes('--all'))
When --all was passed, this evaluated to false because:
false || (true && false) = false
Fix: Explicitly include --all in both conditions:
BUILD_MINILM = args.includes('--all') || args.includes('--minilm') || \!args.includes('--codet5')
BUILD_CODET5 = args.includes('--all') || args.includes('--codet5')
Now the behavior is correct:
- No flags: MiniLM only (default)
- --minilm: MiniLM only
- --codet5: CodeT5 only
- --all: Both MiniLM and CodeT51 parent f434195 commit 14abc4e
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
| 57 | + | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| |||
0 commit comments