Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not saving to history.yml when using smashing start -d #70

Closed
yasa1987 opened this issue Jun 7, 2017 · 2 comments
Closed

Not saving to history.yml when using smashing start -d #70

yasa1987 opened this issue Jun 7, 2017 · 2 comments

Comments

@yasa1987
Copy link

yasa1987 commented Jun 7, 2017

Hello, it's the same issue than in Dashing (Shopify/dashing#244) and that was fixed into Dashing-Contrib (Shopify/dashing#268)

Could you import this feature ? As you mentionned here (https://github.com/QubitProducts/dashing-contrib/issues/40) that dashing-contrib is not compatible I don't want to install it and break everything...

I'm not a Ruby developer otherwise I'd do it myself and send a patch
Thanks in advance

@yasa1987
Copy link
Author

yasa1987 commented Jun 7, 2017

Uh I did found something by myself : the example init.d script I found kills the process with a 9 (SIGKILL) signal instead of a 2 (SIGINT) signal. It explains everything.

This is the script you should add into the wiki, with some changes
https://gist.github.com/gregology/5313326#gistcomment-833636
Just replace --signal 9 with --signal 2 and adapt the pathes

It's more a problem related to a missing part of documentation (and to the user) than with the code.
Sorry for that...

@terraboops
Copy link

100% agreed, we are lacking hugely on operational documentation. We've got outstanding issues to create packages for various OS's, which would negate the need for lots of docs (beyond install instructions).

That being said, feel free to add our example init script to the wiki for now. Closing issue, thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants