From 9077047ca1f2f321bc622c088e5fc9a8dcf2ec22 Mon Sep 17 00:00:00 2001 From: Ihor Duzhyk Date: Tue, 29 Oct 2024 12:59:28 +0200 Subject: [PATCH 1/2] Fixed FileType enums and descriptions --- spec/openapi.yaml | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/spec/openapi.yaml b/spec/openapi.yaml index 29163d14..49f91142 100644 --- a/spec/openapi.yaml +++ b/spec/openapi.yaml @@ -2442,23 +2442,35 @@ paths: type: string fileType: description: >- - Unique identifier for the file type. To allow translation + A unique identifier for the file type. To allow translation imports, XML and JSON files must be uploaded with `source_key_paths` defined. enum: - android - ios - gettext + - html - java_properties - - yaml + - xliff - xml - json + - docx + - pptx + - xlsx + - idml - qt - resx + - plain_text - csv - - pres - - stringsdict - srt + - stringsdict + - xls + - doc + - ppt + - pres + - madcap + - yaml + - markdown type: string translationState: description: | @@ -11253,7 +11265,7 @@ components: format: 'YYYY-MM-DDThh:mm:ssZ' type: string fileType: - description: The type of file + description: A unique identifier for the file type. enum: - android - ios @@ -11401,7 +11413,7 @@ components: format: 'YYYY-MM-DDThh:mm:ssZ' type: string fileType: - description: The type of file + description: A unique identifier for the file type. enum: - android - ios @@ -11513,7 +11525,7 @@ components: description: The number of excluded words in the uploaded file type: integer fileType: - description: The type of file + description: A unique identifier for the file type. enum: - android - ios From ef3ca300a032cfbb0c399b574879065156a21953 Mon Sep 17 00:00:00 2001 From: Ihor Duzhyk Date: Tue, 29 Oct 2024 17:32:43 +0200 Subject: [PATCH 2/2] fixes after code review --- spec/openapi.yaml | 113 ++-------------------------------------------- 1 file changed, 4 insertions(+), 109 deletions(-) diff --git a/spec/openapi.yaml b/spec/openapi.yaml index 49f91142..524e839c 100644 --- a/spec/openapi.yaml +++ b/spec/openapi.yaml @@ -2446,31 +2446,7 @@ paths: imports, XML and JSON files must be uploaded with `source_key_paths` defined. enum: - - android - - ios - - gettext - - html - - java_properties - - xliff - - xml - - json - - docx - - pptx - - xlsx - - idml - - qt - - resx - - plain_text - - csv - - srt - - stringsdict - - xls - - doc - - ppt - - pres - - madcap - - yaml - - markdown + $ref: '#/components/schemas/FileType/enum' type: string translationState: description: | @@ -11265,34 +11241,7 @@ components: format: 'YYYY-MM-DDThh:mm:ssZ' type: string fileType: - description: A unique identifier for the file type. - enum: - - android - - ios - - gettext - - html - - java_properties - - xliff - - xml - - json - - docx - - pptx - - xlsx - - idml - - qt - - resx - - plain_text - - csv - - srt - - stringsdict - - xls - - doc - - ppt - - pres - - madcap - - yaml - - markdown - type: string + $ref: '#/components/schemas/FileType' fileUri: description: A unique identifier for the uploaded file type: string @@ -11413,34 +11362,7 @@ components: format: 'YYYY-MM-DDThh:mm:ssZ' type: string fileType: - description: A unique identifier for the file type. - enum: - - android - - ios - - gettext - - html - - java_properties - - xliff - - xml - - json - - docx - - pptx - - xlsx - - idml - - qt - - resx - - plain_text - - csv - - srt - - stringsdict - - xls - - doc - - ppt - - pres - - madcap - - yaml - - markdown - type: string + $ref: '#/components/schemas/FileType' fileUri: description: A unique identifier for the uploaded file type: string @@ -11525,34 +11447,7 @@ components: description: The number of excluded words in the uploaded file type: integer fileType: - description: A unique identifier for the file type. - enum: - - android - - ios - - gettext - - html - - java_properties - - xliff - - xml - - json - - docx - - pptx - - xlsx - - idml - - qt - - resx - - plain_text - - csv - - srt - - stringsdict - - xls - - doc - - ppt - - pres - - madcap - - yaml - - markdown - type: string + $ref: '#/components/schemas/FileType' fileUri: description: A unique identifier for the uploaded file type: string