Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Pluralsight.Crypto library with a cross-platform alternative #1

Open
markjamesm opened this issue Jan 16, 2023 · 2 comments
Open

Replace Pluralsight.Crypto library with a cross-platform alternative #1

markjamesm opened this issue Jan 16, 2023 · 2 comments
Labels
bug Something isn't working
Milestone
1.0

Comments

@markjamesm
Copy link
Collaborator

markjamesm commented Jan 16, 2023 •
edited
Loading

Currently Dioscuri only builds on Windows. This is because the library used to generate an X.509 certificate (Pluralsight.Crypto) is on .NET Framework and makes win32 API calls:

Package 'Pluralsight.Crypto 1.1.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework 'net6.0'. This package may not be fully compatible with your project.

Need to replace this library, possibly by making use of the .NET CertificateRequest
@markjamesm markjamesm added the bug Something isn't working label Jan 16, 2023
@markjamesm markjamesm added this to the 1.0 milestone Jan 16, 2023
@markjamesm markjamesm mentioned this issue Jan 16, 2023
Merged
@markjamesm markjamesm changed the title Replace Pluralsight.Crypto.CreateSelfSignedCertificate() with a cross-platform alternative Replace Pluralsight.Crypto library with a cross-platform alternative Jan 16, 2023
@markjamesm
Copy link
Collaborator Author

Dioscuri now builds on Mac, but there's a bug in which a certificate validation error occurs. Need to investigate further.

@markjamesm
Copy link
Collaborator Author

When Gemini.Fetch is set to secure mode, the Client crashes on Mac when a new request is made. Looking at the code inside the SmolNetSharp library, I need to debug what might be happening with the certificate chain on Mac.

connectInsecure variable

AlwaysAccept:

https://github.com/markjamesm/Dioscuri/blob/master/SmolNetSharp/Gemini.cs#L139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@markjamesm