Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crafting items while the Server is restarting #2711

Open
variananora opened this issue Jan 12, 2021 · 5 comments
Open

Crafting items while the Server is restarting #2711

variananora opened this issue Jan 12, 2021 · 5 comments
Labels
🐞 Bug Report A bug that needs to be fixed.

Comments

@variananora
Copy link
Member

📍 Description (REQUIRED)

Item in Auto Enchanter or Auto Disenchanter will disappear after a server reboot.

https://youtu.be/CoIFcN7B7f8

📑 Steps to reproduce the Issue (REQUIRED)

  1. Use Auto Disenchanter or Auto Enchanter
  2. Reboot the server
  3. Item is gone

💡 Expected behavior (REQUIRED)

The item inside Auto Enchanter or Auto Disenchanter should not be missing

📜 Server Log

https://pastebin.com/xV7gUAn2

📂 /error-reports/ Folder

There is no error log.

🧭 Environment (REQUIRED)

  • Server Software: git-Paper-403
  • Minecraft Version: 1.16.4
  • Slimefun Version: DEV-780
  • CS-CoreLib Version: DEV-79
    (Optional, idk why i'm including this, just incase.)
  • BentoBox Version: 1.15.3
    • Caveblock Addons: 1.14.2
      image
@variananora variananora added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🐞 Bug Report A bug that needs to be fixed. labels Jan 12, 2021
@TheBusyBiscuit TheBusyBiscuit removed the 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. label Jan 12, 2021
@TheBusyBiscuit TheBusyBiscuit changed the title Item in Auto (Dis)enchant will disappear when the server restarted. Items in machines do not persist through Server restarts. Jan 12, 2021
@TheBusyBiscuit
Copy link
Member

That's not really a bug, it's just the way the system works and it always did so.
This is probably not going to be "fixed" or more like "added" within the next year or two.
But I guess I will leave it open incase someone else sees it, perhaps we can make it a Hacktoberfest issue in october XD

@oahawhool
Copy link

Keep in mind, the actual item, if it finishes 'cooking' does remain in the machine through a reboot.
It's only items that are in the process of being completed, that vanish.

@TheBusyBiscuit TheBusyBiscuit changed the title Items in machines do not persist through Server restarts. Crafting items while the Server is restarting Jan 13, 2021
@Tarluin
Copy link

Tarluin commented Apr 5, 2021

Several years ago it used to dupe the item being enchanted/disenchanted, it was changed to this behavior back then to fix the dupe.

@JinOuYongGu
Copy link

JinOuYongGu commented Apr 8, 2021

If the auto enchanter doesn't take the items at the beginning of the enhancement, but when the enchant just finished, the items won't be lost.
That is, when the server restart, the items remain in the container. What we lost is just "enchant progress", but not the equipments.
I think it could be a safe solution.

@iTwins
Copy link
Contributor

iTwins commented Aug 28, 2023

A possible solution could be:
On shutdown -> save machine operation to blockstorage
On startup -> check blockstorage for machine operation -> if found load the machine operation and continue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Report A bug that needs to be fixed.
Projects
None yet
Development

No branches or pull requests

6 participants