Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Remove Promise dependency for Knit core #199

Closed
Sleitnick opened this issue Mar 8, 2022 · 1 comment
Closed

Remove Promise dependency for Knit core #199

Sleitnick opened this issue Mar 8, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Sleitnick
Copy link
Owner

Just use coroutines instead of promises. Light-weight and easier for users to understand. Promises a great, but a little overkill for what Knit is trying to accomplish on startup.

Another current issue is that promises can hide errors on Knit lifecycle methods, which have to be caught with :catch(). It is better to fail hard if an error comes up on startup.

@Sleitnick Sleitnick self-assigned this Mar 8, 2022
@Sleitnick Sleitnick added the enhancement New feature or request label Mar 8, 2022
@Sleitnick
Copy link
Owner Author

This will force a major version increment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant