Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility issues #15

Open
cclauss opened this issue Jun 17, 2019 · 1 comment
Open

Python 3 compatibility issues #15

cclauss opened this issue Jun 17, 2019 · 1 comment

Comments

@cclauss
Copy link

cclauss commented Jun 17, 2019

Python 2 end of life is in less than 200 days...

flake8 testing of https://github.com/SlavikMIPT/tgcloud on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./dedupfs/get_memory_usage.py:42:13: E999 SyntaxError: invalid syntax
    print msg % (format_size(counter), format_size(new_memory_usage), format_size(difference), format_size(deviation))
            ^
./dedupfs/fuse.py:59:34: E999 SyntaxError: invalid syntax
                           (var, `pattern`))
                                 ^
./dedupfs/dedupfs.py:49:19: E999 SyntaxError: invalid syntax
except ImportError, e:
                  ^
3     E999 SyntaxError: invalid syntax
3

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

  • F821: undefined name name
  • F822: undefined name name in __all__
  • F823: local variable name referenced before assignment
  • E901: SyntaxError or IndentationError
  • E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@VadVergasov
Copy link

VadVergasov commented Jun 17, 2019

Run this threw python2, as it showed on https://habr.com/en/company/vds/blog/456290/ you need to run

python3.6 download_service.py

with python 3, but

python dedupfs/dedupfs.py --block-size 10240000 storage/

with python 2. Also, download_service.py have the first line, which shows that it is python3, but dedupfs have python 2.
Hope it helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants