Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkillAPI renamed to Fabled #317

Open
Travja opened this issue May 19, 2024 · 3 comments
Open

SkillAPI renamed to Fabled #317

Travja opened this issue May 19, 2024 · 3 comments
Labels
integration Is related to an external plugin under testing A solution has been proposed

Comments

@Travja
Copy link

Travja commented May 19, 2024

I just want to take the opportunity to inform you that SkillAPI has undergone a rename and is now Fabled. The new resource is located at the Maven coordinates below. This change also renames the main entry point for API operations and the packages associated with the classes. The studio.magemonkey.fabled.Fabled class should be used instead of SkillAPI, though the api should remain backwards compatible. These compatibility classes are likely to be removed at some point in the future, so these should be updated. Supporting older versions of SkillAPI prior to the rename may still be important, so I'd recommend setting up a try-catch where you try the Fabled-based implementation and fall back to the SkillAPI implementation on an exception.

<repository>
    <id>sonatype</id>
    <url>https://s01.oss.sonatype.org/content/repositories/snapshots</url>
</repository>
...
<dependency>
    <groupId>studio.magemonkey</groupId>
    <artifactId>fabled</artifactId>
    <version>1.0.0-R0.21-SNAPSHOT</version>
</dependency>
@SkytAsul
Copy link
Owner

Thanks for the heads-up. It seems like you are talking about ProSkillAPI though, not regular SkillAPI?

@Travja
Copy link
Author

Travja commented May 19, 2024

Yes, that's correct.

SkytAsul added a commit that referenced this issue Jun 8, 2024
@SkytAsul
Copy link
Owner

SkytAsul commented Jun 9, 2024

May you try the #407 build and tell me if it works correctly?

@SkytAsul SkytAsul added under testing A solution has been proposed integration Is related to an external plugin labels Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Is related to an external plugin under testing A solution has been proposed
Projects
None yet
Development

No branches or pull requests

2 participants