Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[don't implement] Add new fields to user model #156

Open
meeh0w opened this issue Mar 16, 2022 · 2 comments · May be fixed by #178
Open

[don't implement] Add new fields to user model #156

meeh0w opened this issue Mar 16, 2022 · 2 comments · May be fixed by #178
Assignees
@ro-tex
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@meeh0w
Copy link

meeh0w commented Mar 16, 2022

Overview

For the new Accounts Dashboard, we need to add a few new fields to the user model.

New fields are:

  • display name
  • profile picture url

image
@meeh0w meeh0w added the enhancement New feature or request label Mar 16, 2022
@ro-tex
Copy link
Contributor

ro-tex commented Mar 31, 2022

@meeh0w can you remind me what we decided about the picture link validation? Do I need to do any or should I just accept any string there?

@ro-tex ro-tex linked a pull request Mar 31, 2022 that will close this issue
Draft
5 tasks
@meeh0w
Copy link
Author

meeh0w commented Apr 1, 2022 •
edited
Loading

@ro-tex Always good to have a proper validation on the backend imho, as frontend is easy to work around, but I'm not sure what we can (and want) to check for.

On my side I'll just make sure the file input only accepts images and maybe add some size validation. Then I'll just include a (sky?)link to the file in the PUT /user request.

@ro-tex ro-tex changed the title Add new fields to user model [obsolete?] Add new fields to user model Apr 6, 2022
@ro-tex ro-tex added the invalid This doesn't seem right label Apr 6, 2022
@ro-tex ro-tex changed the title [obsolete?] Add new fields to user model [don't implement] Add new fields to user model Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ro-tex ro-tex

Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ON HOLD] User name and profile picture fields SkynetLabs/skynet-accounts
2 participants
@ro-tex @meeh0w