Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Start/Stop #114

Open
ro-tex opened this issue Dec 20, 2021 · 0 comments
Open

Use Start/Stop #114

ro-tex opened this issue Dec 20, 2021 · 0 comments

Comments

@ro-tex
Copy link
Contributor

ro-tex commented Dec 20, 2021

Overview

Using only the context for shutting down background threads leads to unclean shutdowns. Use specific start/stop methods.

Design or Proposal

Start should create a thread-wide waitgroup and the Stop should wait on it to finish before exiting.
When we Start the service from main, we should also defer Stop().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant