Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Do not validate host for resolve endpoint #1437

Closed
louischan-oursky opened this issue May 21, 2020 · 2 comments · Fixed by #1439
Closed

Do not validate host for resolve endpoint #1437

louischan-oursky opened this issue May 21, 2020 · 2 comments · Fixed by #1439
Assignees
@louischan-oursky

Comments

@louischan-oursky
Copy link
Contributor

louischan-oursky commented May 21, 2020 •
edited
Loading

Discussed with the team and we have the following conclusions
@louischan-oursky louischan-oursky self-assigned this May 21, 2020
@louischan-oursky
Copy link
Contributor Author

Since we do not resolve relative URL now, maybe we can even remove validate host middleware. Thoughts?

@kiootic
Copy link
Contributor

kiootic commented May 21, 2020

We're still constructing URLs using Host header through urlprefix.Provider, so it should not be removed.

@louischan-oursky louischan-oursky changed the title Auth Gear resolve endpoint should not validate host Mount resolve endpoint at root router May 22, 2020
@louischan-oursky louischan-oursky changed the title Mount resolve endpoint at root router Do not validate host for resolve endpoint May 22, 2020
louischan-oursky added a commit to louischan-oursky/skygear-server that referenced this issue May 22, 2020
@louischan-oursky
Do not validate host for resolve endpoint
315e2ce 
ref SkygearIO#1437
@louischan-oursky louischan-oursky mentioned this issue May 22, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@louischan-oursky louischan-oursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not validate host for resolve endpoint louischan-oursky/skygear-server
2 participants
@kiootic @louischan-oursky