Skip to content
This repository has been archived by the owner on Dec 9, 2019. It is now read-only.

Consider using Roboto Mono instead of Courier New for code display #465

Open
chpapa opened this issue Feb 20, 2017 · 5 comments
Open

Consider using Roboto Mono instead of Courier New for code display #465

chpapa opened this issue Feb 20, 2017 · 5 comments

Comments

@chpapa
Copy link
Contributor

chpapa commented Feb 20, 2017

Used by Firebase doc, Suggested by @mayyuen318

@chpapa
Copy link
Contributor Author

chpapa commented Feb 20, 2017

@rickmak
Copy link
Member

rickmak commented Feb 20, 2017

Honestly, I think the choice of font need professional knowledge. Which I don't have much insight. For profession input, loop in frnak. Follow is my 2 cent.

From user point of view, choice of font weight, spacing and size within a font family matter more. Even more than the choice of Font-family.

So a sensible point to start with is: why you think firebase doc is more readable?

For me, the biggest problem of existing code display is font-weight too light.

@tensiuyan
Copy link
Collaborator

In the coming doc site minor UI updates (ref#516), we will update the font family as well. We've used Lato in the design (which is the same as the one we use in the portal). Feel free to give comments: https://projects.invisionapp.com/share/FHBE4OAD8#/screens/230045331

@tensiuyan tensiuyan mentioned this issue Apr 25, 2017
10 tasks
@mayyuen318
Copy link
Contributor

@tensiuyan I have commented on InvisionApp. I asked Siutao to bold a few words in the first paragraph and see the difference between bold and not bold. A bit feel like all the words are bold. Though @rickmak might think this font weight is great?

I checked the font - 16px, bold & regular on Google Font
It looks fine. Just dunno why it doesn't like very good on InvisionApp ><
Let me wait for Siutao's update.

@rickmak
Copy link
Member

rickmak commented Apr 26, 2017

If you really ask me to comment.... I think the letter spacing and line spacing need to be adjusted. Not the font. The font looks fine to me.

The top margin and the bottom margin of code box away from text is different....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants