Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate createMessage function #52

Open
howawong opened this issue Aug 10, 2017 · 2 comments
Open

Deprecate createMessage function #52

howawong opened this issue Aug 10, 2017 · 2 comments

Comments

@howawong
Copy link
Contributor

createMessage function is too similar to addMessage function. It is better to deprecate createMessage.

@carmenlau
Copy link
Contributor

Agree that addMessage is more flexible for sending a message, but for me I think createMessage looks like to shorthand for user to sending message that they don't have to create the message object. So we could keep both? :P

It is not urgent, so I just remove it from the milestone first

@rickmak
Copy link
Member

rickmak commented Nov 20, 2017

According to design principle

Obvious means that API references should clearly reveal how to do something. Avoid redundancy for the same use cases. Make the API obvious how to do certain things. Avoid acronyms. It will be easier to learn and easier to remember for users.

We should provide one obvious way to do one thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants