Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loading #1326

Closed
weole opened this issue Jan 22, 2025 · 10 comments
Closed

Infinite loading #1326

weole opened this issue Jan 22, 2025 · 10 comments
Labels
Milestone

Comments

@weole
Copy link

weole commented Jan 22, 2025

Describe the bug
Searching videos and loading trending page results in infinite loading.

To Reproduce
Steps to reproduce the behavior:

  1. Open Skytube
  2. Go to trending or enter search bar.

Expected behavior
Videos or channels should appear.

Screenshots
Screenshot_20250121-192147.png

Setup:

  • Android version: 11

  • Is Your device rooted? No.

  • Do You use Tor or any VPN service with your device? No.

  • App source [e.g. FDroid, Downloaded from GitHub, self build]
    Github

  • App Version [e.g. v2.977]
    v2.992

  • App Flavour [e.g. Extra or OSS]

Additional context
Add any other context about the problem here.

@mckaygerhard
Copy link

mckaygerhard commented Jan 22, 2025

ok i confirm this issue.. the backend is the same with optimizations so you can download the prevous version and still play your videos while developer find a solution for version https://github.com/SkyTubeTeam/SkyTube/releases/tag/v2.992

workaround : return to version https://github.com/SkyTubeTeam/SkyTube/releases/tag/v2.991

my only hints is the new pipe extractor as root cause i guess from commits f0283ea and a2a5fe1 .. related to #1327

@mckaygerhard
Copy link

@gzsombor i confirmed that changes TeamNewPipe/NewPipeExtractor@v0.24.3...v0.24.4 are only for ios and seems on androit are not well tested.. any video can be player..

TeamNewPipe/NewPipe#11803 seems related and must be followed

@noskill24
Copy link

workaround : return to version https://github.com/SkyTubeTeam/SkyTube/releases/tag/v2.991

v2.991 also doesn't play any videos... but it loads the list successfully.

@drogga
Copy link
Contributor

drogga commented Jan 22, 2025

@mckaygerhard
Commenting unprepared here as well/again I see...
All the other versions are broken now, it would've been nice if you actually tested them before falsely suggesting not working solutions or workarounds.
The mention of iOS is for the user agent and other spoof methods and it's very much related to android and is to bypass the blocks.

@gzsombor
Is this a joke ?, did you bothered to test loading or playing anything before pushing those commits and the broken updated version ?, because I test my changes before creating PRs. Please delete or replace the files of that broken v2.992. Thank You.

Edit ²: @gzsombor - Pls. remove the dead http://skytube-app.com link from the Wiki [Tab].

@gzsombor
Copy link
Member

Thanks for the report, sorry, it was a rushed update yesterday night, when I've noticed that I hadn't had a single video fetched in the last 24 hours. I thought, I could just update the NewPipeExtractor in 5 minutes...

@gzsombor gzsombor added this to the v2.993 milestone Jan 22, 2025
@mckaygerhard
Copy link

@gzsombor thanks.. for your work! now all the things worked so great

under androit 13 now version 2.993 loads the list and play short videos up to 60 minutes.. but as surprise videos tht does not play in older versions now plays.. long videos (about 1 to 3 hours) now also plays too! GREAT! i hate so mch androit but well we have google and M$ shit companies

@drogga i already tested .. i comment to you that was happened: i never upgrade .. only after some weeks .. so i play videos always in the afternoon and i was just plying my videos normally all those days .. i decided to upgrade after some hours just for curiosity

so basically my older version was working before upgrade.. and as the famous saying goes: curiosity killed the cat...

@drogga
Copy link
Contributor

drogga commented Jan 23, 2025

Thanks @gzsombor, also for removing the dead link from the Wiki, but please also see: #1253 (comment) and if not anything else, at least edit the ReadMe, /app/build.gradle and Github Pages (the gh-pages branch can probably be brought live/online in GH itself, but NVM, just address the dead links for now and thank you again).

Oh and consider inviting me as a member/collaborator, so I can handle some things that otherwise I can't.

Question: How to access the 3 top right buttons from a channel screen with the new huge, ugly and unnecessary matrial Subscribe button ?, those three: https://github.com/SkyTubeTeam/SkyTube/blob/master/screenshots/channel.jpg
The old one wasn't in the way and was way better...

@drogga
Copy link
Contributor

drogga commented Feb 1, 2025

The playback is broken again btw and the extractor isn't updated at the time of typing this, so I doubt anything can be done here to address the problem.

@mckaygerhard
Copy link

@drogga its working check picture.. also this issue is about infinite loading of main list of video.. open a new issue for your problem that is about a new format not playing .. as the pipe extrator has it! some videos are not playing due that! puff asking to organize issues but dont take note of the problem

Image

@drogga
Copy link
Contributor

drogga commented Feb 2, 2025

mckaygerhard

🤦 I'm not using the "new" (DASH) format, because it's unwatchable, even when Google doesn't activity try to sabotage the playback/fetch, which is not new anymore, but the option is called like this in this app. NewPipe plays DASH/HLS just fine, except when there are issues caused by G./YT that circumvent the NP's patches, which ST doesn't fully incorporate, at least not ones for the rate limit / throttle of the DASH format (means separate audio stream from the video, unlike the 360p merged MP4 ones).

Also I told you already to not mention/tag/summon me again. Please also don't tell me what to do and stop spreading BS about things you don't actually understand, but only think that you do, leave the thinking to us - the ones that actually contribute with something.

Oh, and btw - I saw your comment in the Legacy repo, typing nonsense again - Tubular is a fork of NewPipe, which also uses the same Extractor (like many others), so please (again) > avoid typing nonsense or commenting at all, I'm asking nicely again, before taking actions.

Let's not forget that you, yourself linked/mentioned this particular ticket as duplicate in another one regarding the playback issue and now you are trying to lecture me 😆 and that after ignoring what I told you previously...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants