Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Skript#getExpressions to return a collection instead of an iterator #6175

Open
1 task done
Fusezion opened this issue Nov 7, 2023 · 3 comments
Open
1 task done

Change Skript#getExpressions to return a collection instead of an iterator #6175

Fusezion opened this issue Nov 7, 2023 · 3 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@Fusezion
Copy link
Contributor

Fusezion commented Nov 7, 2023

Suggestion

Change Skript#getExpressons() from returning an Iterator to a Collection

Why?

All other Skript#get... methods return a collection and while this is a small and minor change it doesn't make sense to have this be an odd one out if non of the other 4+ methods did this,

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@APickledWalrus
Copy link
Member

This is (or should be) handled in #5331

@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Nov 8, 2023
@Fusezion
Copy link
Contributor Author

Is this still being handled to a degree in #6246 with the closing of original pr?

@APickledWalrus
Copy link
Member

It is handled in that PR, I'll have to make note

@APickledWalrus APickledWalrus added the PR available Issues which have a yet-to-be merged PR resolving it label Sep 20, 2024
@APickledWalrus APickledWalrus mentioned this issue Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sovdeeth @APickledWalrus @Fusezion