Fix getting java functions causing casting errors (#8213)

Fix #getJavaFunctions causing casting errors

Author: Efnilite

src/main/java/ch/njol/skript/doc/Documentation.java

@@ -6,9 +6,7 @@
 import ch.njol.skript.lang.ExpressionInfo;
 import ch.njol.skript.lang.SkriptEventInfo;
 import ch.njol.skript.lang.SyntaxElementInfo;
-import org.skriptlang.skript.common.function.DefaultFunction;
 import ch.njol.skript.lang.function.Functions;
-import ch.njol.skript.lang.function.JavaFunction;
 import ch.njol.skript.lang.function.Parameter;
 import ch.njol.skript.registrations.Classes;
 import ch.njol.skript.util.Utils;
@@ -153,7 +151,7 @@ private static void asSql(final PrintWriter pw) {
 				"examples VARCHAR(2000) NOT NULL," +
 				"since VARCHAR(100) NOT NULL" +
 				");");
-		for (ch.njol.skript.lang.function.Function<?> func : Functions.getDefaultFunctions()) {
+		for (ch.njol.skript.lang.function.Function<?> func : Functions.getFunctions()) {
 			assert func != null;
 			insertFunction(pw, func);
 		}

src/main/java/ch/njol/skript/doc/DocumentationIdProvider.java

@@ -103,7 +103,7 @@ public static <T> String getId(SyntaxInfo<? extends T> syntaxInfo) {
 	 * @return the documentation ID of the function
 	 */
 	public static String getId(Function<?> function) {
-		int collisionCount = calculateCollisionCount(Functions.getJavaFunctions().iterator(),
+		int collisionCount = calculateCollisionCount(Functions.getFunctions().iterator(),
 			javaFunction -> function.getName().equals(javaFunction.getName()),
 			javaFunction -> javaFunction == function);
 		return addCollisionSuffix(function.getName(), collisionCount);

src/main/java/ch/njol/skript/doc/HTMLGenerator.java

@@ -6,7 +6,6 @@
 import ch.njol.skript.lang.*;
 import ch.njol.skript.lang.function.Function;
 import ch.njol.skript.lang.function.Functions;
-import ch.njol.skript.lang.function.JavaFunction;
 import ch.njol.skript.registrations.Classes;
 import com.google.common.base.Joiner;
 import com.google.common.collect.Lists;
@@ -18,7 +17,6 @@
 import org.jetbrains.annotations.Nullable;
 import org.skriptlang.skript.lang.entry.EntryData;
 import org.skriptlang.skript.lang.entry.EntryValidator;
-import org.skriptlang.skript.common.function.DefaultFunction;
 import org.skriptlang.skript.lang.structure.StructureInfo;
 
 import java.io.File;
@@ -333,7 +331,7 @@ else if (!filesInside.getName().matches("(?i)(.*)\\.(html?|js|css|json)")) {
 					}
 				}
 				if (genType.equals("functions") || isDocsPage) {
-					List<Function<?>> functions = new ArrayList<>(Functions.getDefaultFunctions());
+					List<Function<?>> functions = new ArrayList<>(Functions.getFunctions());
 					functions.sort(functionComparator);
 					for (Function<?> info : functions) {
 						assert info != null;

src/main/java/ch/njol/skript/doc/JSONGenerator.java

@@ -503,7 +503,7 @@ public void generate(@NotNull Path path) throws IOException {
 		jsonDocs.add("structures", generateStructureElementArray(source.syntaxRegistry().syntaxes(SyntaxRegistry.STRUCTURE)));
 		jsonDocs.add("sections", generateSyntaxElementArray(source.syntaxRegistry().syntaxes(SyntaxRegistry.SECTION)));
 		jsonDocs.add("types", generateClassInfoArray(Classes.getClassInfos().iterator()));
-		jsonDocs.add("functions", generateFunctionArray(Functions.getDefaultFunctions().iterator()));
+		jsonDocs.add("functions", generateFunctionArray(Functions.getFunctions().iterator()));
 
 		try {
 			Files.writeString(path, GSON.toJson(jsonDocs));

src/main/java/ch/njol/skript/lang/function/Functions.java

@@ -16,6 +16,7 @@
 import org.skriptlang.skript.lang.script.Script;
 
 import java.util.*;
+import java.util.stream.Collectors;
 
 /**
  * Static methods to work with functions.
@@ -445,21 +446,23 @@ public static void clearFunctions() {
 	}
 
 	/**
-	 * @deprecated Use {@link #getDefaultFunctions()} instead.
+	 * @deprecated Use {@link #getFunctions()} instead.
 	 */
-	@SuppressWarnings({"unchecked"})
 	@Deprecated(forRemoval = true, since = "INSERT VERSION")
 	public static Collection<JavaFunction<?>> getJavaFunctions() {
 		// We know there are only Java functions in that namespace
-		return (Collection<JavaFunction<?>>) (Object) javaNamespace.getFunctions();
+		return javaNamespace.getFunctions().stream()
+				.filter(it -> it instanceof JavaFunction<?>)
+				.map(it -> (JavaFunction<?>) it)
+				.collect(Collectors.toSet());
 	}
 
 	/**
 	 * Returns all functions registered using Java.
 	 *
 	 * @return All {@link JavaFunction} or {@link DefaultFunction} functions.
 	 */
-	public static Collection<Function<?>> getDefaultFunctions() {
+	public static Collection<Function<?>> getFunctions() {
 		return javaNamespace.getFunctions();
 	}