Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify CL for newly checked out/marked files. #24

Open
Malrog opened this issue Mar 1, 2022 · 4 comments
Open

Specify CL for newly checked out/marked files. #24

Malrog opened this issue Mar 1, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@Malrog
Copy link

Malrog commented Mar 1, 2022

It would be nice to have the option to select from my existing pending CLs when prompted for check out/add/delete, and have the file added to that CL (similar to how p4vs does it). This could also provide the option to create a new CL, although that's a lesser QoL feature.

An alternative to this would be to have an 'active' CL that the user can define (perhaps on a toolbar or via a menu), and then all check out/add/delete operations will use that CL. This would be an improvement on p4vs, which prompts for CL every single time. 😅

@SimpsonGSD SimpsonGSD changed the title [Enhancement]Specify CL for newly checked out/marked files. Specify CL for newly checked out/marked files. Mar 1, 2022
@SimpsonGSD SimpsonGSD added the enhancement New feature or request label Mar 1, 2022
@SimpsonGSD
Copy link
Owner

So this feature might be considered outside of the scope of this plugin.

In order to keep this plugin from hindering VS performance (like P4VS does) I don't like providing features that require asking the server for information. Unless it can be completely disabled and have no impact on the core functionality.

If I have a GUI element which requires information from the server then I have to block and wait for the result. This can be painful if a user has a slow connection or unstable server as it will lock up VS.
Alternatively I can do this async but then the GUI element might not be populated readily enough causing an annoying user experience.

I will have a think about it.

@fido9dido
Copy link

@SimpsonGSD, if you only have an issue with people with slow connection, then you can simply add it as optional feature where you can enable/disable it from the plugin settings

@SimpsonGSD
Copy link
Owner

It's more that I don't want to add features that require reading data from the server because it's not immediately obvious to the user why it's failing or being slow. I just want this extension to be a no hassle Perforce extension.

The best I can think of is having a menu text box where you can specifiy the default CL number but if the CL number doesn't exist then it would just fail. It doesn't seem like a great UX choice to me, however, I could hide this behind an advanced option if it would suit your needs.

@jamesedgar
Copy link

I am also looking for this feature, and I think putting it behind an advanced options menu item would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants