Skip to content

Commit 9feb925

Browse files
author
Dave North
committed
Re-order build step, fix formatting
1 parent 1e47771 commit 9feb925

File tree

2 files changed

+19
-25
lines changed

2 files changed

+19
-25
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ install:
66
- pip install flake8
77
before_script:
88
- flake8 --version
9-
script:
109
- flake8 --ignore=E501 lambda/
10+
script:
1111
- ./build.sh
1212
deploy:
1313
provider: releases

lambda/iam-notify-slack.py

Lines changed: 18 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
import os
33
from slacker import Slacker
44

5-
65
def send_to_slack(message, attachment, channel, key):
76
status = True
87
print("sending slack message " + message)
@@ -57,29 +56,25 @@ def lambda_handler(event, context):
5756
post_to_slack = True
5857
object_field_name = ""
5958
object_field_value = ""
60-
policy_name = event['detail']['requestParameters']['policyArn'].split(':')[
61-
5]
59+
policy_name = event['detail']['requestParameters']['policyArn'].split(':')[5]
6260
policy_arn = event['detail']['requestParameters']['policyArn']
6361
elif event_name == "AttachGroupPolicy" or event_name == "DetachGroupPolicy":
6462
post_to_slack = True
6563
object_field_name = "Group"
6664
object_field_value = event['detail']['requestParameters']['groupName']
67-
policy_name = event['detail']['requestParameters']['policyArn'].split(':')[
68-
5]
65+
policy_name = event['detail']['requestParameters']['policyArn'].split(':')[5]
6966
policy_arn = event['detail']['requestParameters']['policyArn']
7067
elif event_name == "AttachUserPolicy" or event_name == "DetachUserPolicy":
7168
post_to_slack = True
7269
object_field_name = "User"
7370
object_field_value = event['detail']['requestParameters']['userName']
74-
policy_name = event['detail']['requestParameters']['policyArn'].split(':')[
75-
5]
71+
policy_name = event['detail']['requestParameters']['policyArn'].split(':')[5]
7672
policy_arn = event['detail']['requestParameters']['policyArn']
7773
elif event_name == "AttachRolePolicy" or event_name == "DetachRolePolicy":
7874
post_to_slack = True
7975
object_field_name = "Role"
8076
object_field_value = event['detail']['requestParameters']['roleName']
81-
policy_name = event['detail']['requestParameters']['policyArn'].split(':')[
82-
5]
77+
policy_name = event['detail']['requestParameters']['policyArn'].split(':')[5]
8378
policy_arn = event['detail']['requestParameters']['policyArn']
8479
else:
8580
print("No support for event " + event_name)
@@ -97,8 +92,7 @@ def lambda_handler(event, context):
9792
operation_user = event['detail']['userIdentity']['userName']
9893
else:
9994
# no user so must be a role
100-
operation_user = event['detail']['userIdentity']['principalId'].split(':')[
101-
1]
95+
operation_user = event['detail']['userIdentity']['principalId'].split(':')[1]
10296
operation_role = event['detail']['userIdentity']['sessionContext']['sessionIssuer']['userName']
10397

10498
operation_user = operation_user + \
@@ -112,21 +106,21 @@ def lambda_handler(event, context):
112106
slack_attachment = [
113107
{
114108
"fallback": "Check the IAM console for details.",
115-
"color": "#36a64f",
109+
"color": "#36a64f",
116110
"title": "View Policy Details in the AWS Console",
117111
"title_link": iam_policy_console_link,
118-
"fields": [
119-
{
120-
"title": "Action Performed",
121-
"value": event_name,
122-
"short": 'false'
123-
},
124-
{
125-
"title": object_field_name,
126-
"value": object_field_value,
127-
"short": 'false'
128-
}
129-
]
112+
"fields": [
113+
{
114+
"title": "Action Performed",
115+
"value": event_name,
116+
"short": 'false'
117+
},
118+
{
119+
"title": object_field_name,
120+
"value": object_field_value,
121+
"short": 'false'
122+
}
123+
]
130124
}
131125
]
132126

0 commit comments

Comments
 (0)