Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Display a poster until loaded #120

Open
4 tasks done
mandliyarajendra11 opened this issue Jul 17, 2023 · 9 comments
Open
4 tasks done

[Feature] Display a poster until loaded #120

mandliyarajendra11 opened this issue Jul 17, 2023 · 9 comments
Labels
Easy easy level issue enhancement Enhacing existing feature google-model-viewer Issue using google-model-viewer SWOC S4 Assigned to SWOC S4 contributor up for grabs open to contributors

Comments

@mandliyarajendra11
Copy link
Contributor

Description

chair image rending very slow

we add new react hook useDeferredValue

Offical website reference about UseDeferredValue -
https://react.dev/reference/react/useDeferredValue

for that we need to update our project version 17 to 18..2 then we able to use this hook

Screenshots

No response

Checklist

  • I have checked the existing issues
  • I have read the [Contributing Guidelines]
  • I am willing to work on this issue (optional)
  • I am a GSSoC'23 contributor
@mandliyarajendra11 mandliyarajendra11 added the enhancement Enhacing existing feature label Jul 17, 2023
@ShwetKhatri2001
Copy link
Owner

There is no image actually. It's directly showing 3D, when it's getting loaded completely and nothing before that.
There is a solution available for that already. No need to use a special hook or update React version.

Here is the solution,
Display a poster until loaded

You may use this poster or generate a new one from https://modelviewer.dev/editor/ .
image

Let me know if you'd like to make the changes given in the example.
I can provide Level-1 for this small change.

@ShwetKhatri2001 ShwetKhatri2001 added gssoc23 Assigned to GSSoC23 contributor level1 up for grabs open to contributors labels Jul 20, 2023
@ShwetKhatri2001
Copy link
Owner

@mandliyarajendra11 Are you open to making the changes mentioned above ?

@mandliyarajendra11
Copy link
Contributor Author

@mandliyarajendra11 Are you open to making the changes mentioned above ?

not now , assign it to someone or close

@ShwetKhatri2001 ShwetKhatri2001 removed gssoc23 Assigned to GSSoC23 contributor level1 labels Dec 10, 2023
@ShwetKhatri2001 ShwetKhatri2001 changed the title [Feature] image slow render [Feature] Display a poster until loaded Dec 10, 2023
@ShwetKhatri2001 ShwetKhatri2001 added the Easy easy level issue label Dec 10, 2023
@Paarisha1
Copy link

I would like to contribute under swoc

@ShwetKhatri2001 ShwetKhatri2001 added the SWOC S4 Assigned to SWOC S4 contributor label Jan 1, 2024
@ShwetKhatri2001
Copy link
Owner

Okay @Paarisha1 . You can work on it, have a look at the requirements mentioned by me above.

@ShwetKhatri2001
Copy link
Owner

Any updates or issues @Paarisha1 ? Please try to complete it in the next 3 days.

@ShwetKhatri2001 ShwetKhatri2001 added google-model-viewer Issue using google-model-viewer and removed up for grabs open to contributors labels Jan 11, 2024
@Paarisha1
Copy link

Sure

@Paarisha1
Copy link

sir i am unable to do it so kindly unassign me

@ShwetKhatri2001
Copy link
Owner

Okay, This issue is open for contributions now.

@ShwetKhatri2001 ShwetKhatri2001 added the up for grabs open to contributors label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy easy level issue enhancement Enhacing existing feature google-model-viewer Issue using google-model-viewer SWOC S4 Assigned to SWOC S4 contributor up for grabs open to contributors
Projects
None yet
Development

No branches or pull requests

3 participants