Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the movie rating of each movie to 1 decimal place #1

Open
ShubhamSKadam opened this issue Feb 5, 2023 · 7 comments · Fixed by #2 · May be fixed by #3
Open

Fix the movie rating of each movie to 1 decimal place #1

ShubhamSKadam opened this issue Feb 5, 2023 · 7 comments · Fixed by #2 · May be fixed by #3

Comments

@ShubhamSKadam
Copy link
Owner

No description provided.

@ShubhamSKadam ShubhamSKadam changed the title Fix the rating to 1 decimal place Fix the movie rating of each movie to 1 decimal place Feb 5, 2023
@alokVerma749
Copy link
Contributor

can you elaborate on this issue

@ShubhamSKadam
Copy link
Owner Author

  1. Go to the live link https://filmpire-ssk.netlify.app/
  2. Click on any movie.
  3. You would see the rating of the movie is displayed in 3 decimal places.

🎯 Your goal is to fix the rating to 1 decimal place.

@alokVerma749
Copy link
Contributor

I would like to take on this issue and work on it. Can you please assign it to me so that I can get started

@ShubhamSKadam
Copy link
Owner Author

@alokVerma749 You can work over the issue.

@alokVerma749 alokVerma749 mentioned this issue Mar 1, 2023
Merged
@alokVerma749
Copy link
Contributor

you can review it.

@ShubhamSKadam ShubhamSKadam reopened this Mar 2, 2023
@ShubhamSKadam
Copy link
Owner Author

I merged it without reviewing. Later I figured out that the changes you made are not reflected in every movie. Please check.

@alokVerma749
Copy link
Contributor

it looks like the production js version didn't support the toFixed() method, if this is the case we can use some alternative of that method.

@alokVerma749 alokVerma749 linked a pull request Mar 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alokVerma749 @ShubhamSKadam