Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check modified lines only, instead of the whole file #48

Open
binarymonkey84 opened this issue Aug 15, 2024 · 1 comment
Open

Check modified lines only, instead of the whole file #48

binarymonkey84 opened this issue Aug 15, 2024 · 1 comment
Labels
enhancement New feature or request open for contributions Feature is not prioritized but something the open source community make pick up

Comments

@binarymonkey84
Copy link

I had thought I'd read somewhere that the default behaviour for Theme Check in this action context was to only check modified lines, but it seems the entire file is checked when it contains any modifications.

Since we work with customising third party themes, when it comes to pull requests, we're only really concerned about code we are introducing to the theme, and not issues with code that isn't "ours".

Can we configure the action to only check modified lines instead of the entire file?

image

@lukeh-shopify
Copy link

👋 Hey @binarymonkey84, thanks for reporting this. I've checked with the team and you are correct that checks are run on the entire modified file, and not simply the changed lines. This was always the expected behaviour and we don't have any immediate plans to prioritize this feature. I'll add an open for contributions label to indicate this is something that can be worked on by the open source community if they wish.

@lukeh-shopify lukeh-shopify added open for contributions Feature is not prioritized but something the open source community make pick up enhancement New feature or request labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request open for contributions Feature is not prioritized but something the open source community make pick up
Projects
None yet
Development

No branches or pull requests

2 participants