Update Readme with links to issue #55 and PR #63 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome to the community and thank you for the pull request. |
ghost
added
the
|
Already signed. How to rerun CLA? Edit: Decided to split the changes into two commits to force the CLA rerun 😄 |
For better visibility and to minimize the number of "duplicate issues" created by people trying the extension, let visitors know ahead about the known bug: not being able to profile a development store (unless a workaround is used).
For better visibility and to minimize the number of "duplicate issues" created by people trying the extension, let visitors know ahead about the known bug: not being able to profile a Storefront Renderer rendered store.
|
@wizardlyhel reason for closing without merge? |
|
SFR and collaborator access are both fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better visibility and to minimize the number of "duplicate issues" created by people trying the extension, let visitors know ahead about the two known bugs: not being able to profile a development store, and not being able to profile a Storefront Renderer rendered store.
What issue does this pull request address?
When new users of the extension get hit with the error message "This page cannot be profiled" they aren't given any reason why. Hence they may open issues that are later closed because it was later found to be one of the two problems: development store (#55) or SFR-rendered store (#63).
What is the solution?
Inform all visitors in the FAQ section of the Readme about these two known issues so they can visit the appropriate issue, utilize the known workaround or subscribe to the pull request for updates.
What should the reviewer focus on and are there any special considerations?
Consider that this would reduce the number of duplicate issues you may get, thus have to manage. Less time managing duplicate issues means more time fixing code 😄