-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App-bridge cnd breaks npm app-bridge navigation menu #267
Comments
+1 |
Did you confirm that the issue is caused by loading the CDN version of app bridge alongside the NPM version? There was an issue with the sidebar navigation yesterday that appears to have been resolved about 10 hours ago. cc @henrytao-me |
@ryanrphillips I just gave it another try and the issue still persists, unfortunately. One issue seems to be resolved though; when you clicked the app itself in the sidebar from an app subpage it would not go to the root page. |
Seems like the problem still persists. On many apps clicking on the app icon on the sidebar from a subpage does not navigate to the root page of the app. |
+1 |
I've also faced the same issue, When I click on the app itself in the sidebar from an app subpage it does not go to the root page. Have any solution for this? |
A fix for this should be merged soon. It's a separate issue. |
While we recommend to use Navigation Menu in App Bridge CDN, if you still want to use it from npm version, you need to disable it in App Bridge CDN. You can do it via meta tag
|
Thank you for the update. But can you give an estimate when the bug is going to be fixed & merged? It passed 17 hours, and I still can see many apps, including mine, are having this problem. Update: the issue has been resolved. |
Hello @henrytao-me ! Is there a list of possible values for the "shopify-disabled-features" meta tag? Thank you! |
Describe the bug
I've been using both versions of app bridge,
@shopify/app-bridge
and.cdn.shopify.com/shopifycloud/app-bridge.js
.The CDN version I use for Toast and the resource picker. The NPM version I use for creating a navigation menu (
actions.NavigationMenu.create()
). This has always worked fine.Starting this evening, the navigation menu renders but the links no longer work.
To Reproduce
Expected behaviour
It should navigate between pages that I click in the navigation menu.
Contextual information
Can we please get a CDN-versioned app bridge like the NPM package?
Packages and versions
List the relevant packages you’re using, and their versions. For example:
https://unpkg.com/@shopify/[email protected]/umd/index.js
https://unpkg.com/@shopify/[email protected]/umd/index.js
Platform
The text was updated successfully, but these errors were encountered: