Skip to content

ZJIT: Improve HIR printout for certain Primitive usages #921

@XrXr

Description

@XrXr

As a fallback for not having a descriptive name for certain kinds of Primitive use, compile.c puts _bi<line_number> as the name in the invokebuiltin opcode.

ruby/compile.c

Line 9349 in 2f151e7

# define BUILTIN_INLINE_PREFIX "_bi"

ZJIT used to include that name in the HIR printout, but that proved problematic for test stability, as incidental changes to the containing .rb file such as documentation update could cause make zjit-test to fail. This kind of names are redacted for now for test stability. ruby#15575

It would be nice to have stable and descriptive printout for these invokebuiltin calls.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions