Skip to content

Commit a058bff

Browse files
authored
Bump build timeout to 25 minutes (#599)
* Bump build timeout to 25 minutes * Upgrade sorbet * Revert server_test separation
1 parent 3bee798 commit a058bff

File tree

5 files changed

+18
-46
lines changed

5 files changed

+18
-46
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- gemfile: "gemfiles/Gemfile-rails-main"
1818
experimental: true
1919
runs-on: ${{ matrix.os }}
20-
timeout-minutes: 15
20+
timeout-minutes: 25
2121
env:
2222
BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }}
2323
continue-on-error: ${{ !!matrix.experimental }}
@@ -38,7 +38,9 @@ jobs:
3838
cache-version: 7
3939

4040
- name: Run tests
41-
run: bundle exec rake
41+
run: |
42+
bundle exec rails db:setup
43+
bundle exec rake
4244
lint:
4345
runs-on: ubuntu-latest
4446
steps:

Gemfile.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -238,15 +238,15 @@ GEM
238238
ruby-progressbar (1.13.0)
239239
ruby2_keywords (0.0.5)
240240
securerandom (0.4.1)
241-
sorbet (0.5.11966)
242-
sorbet-static (= 0.5.11966)
243-
sorbet-runtime (0.5.11966)
244-
sorbet-static (0.5.11966-aarch64-linux)
245-
sorbet-static (0.5.11966-universal-darwin)
246-
sorbet-static (0.5.11966-x86_64-linux)
247-
sorbet-static-and-runtime (0.5.11966)
248-
sorbet (= 0.5.11966)
249-
sorbet-runtime (= 0.5.11966)
241+
sorbet (0.5.12046)
242+
sorbet-static (= 0.5.12046)
243+
sorbet-runtime (0.5.12046)
244+
sorbet-static (0.5.12046-aarch64-linux)
245+
sorbet-static (0.5.12046-universal-darwin)
246+
sorbet-static (0.5.12046-x86_64-linux)
247+
sorbet-static-and-runtime (0.5.12046)
248+
sorbet (= 0.5.12046)
249+
sorbet-runtime (= 0.5.12046)
250250
spoom (1.5.4)
251251
erubi (>= 1.10.0)
252252
prism (>= 0.28.0)

Rakefile

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,10 @@ load "rails/tasks/statistics.rake"
1010
require "bundler/gem_tasks"
1111
require "rake/testtask"
1212

13-
# Since `server.rb` runs within the host Rails application, we want to ensure
14-
# we don't accidentally depend on sorbet-runtime. `server_test` intentionally doesn't use `test_helper`.
15-
# We run `server_test` in a seperate Rake task.
1613
Rake::TestTask.new(:test) do |t|
1714
t.libs << "test"
1815
t.libs << "lib"
19-
t.test_files = FileList["test/**/*_test.rb"] - ["test/ruby_lsp_rails/server_test.rb"]
16+
t.test_files = FileList["test/**/*_test.rb"]
2017
end
2118

22-
Rake::TestTask.new(:server_test) do |t|
23-
t.libs << "test"
24-
t.libs << "lib"
25-
t.test_files = ["test/ruby_lsp_rails/server_test.rb"]
26-
end
27-
28-
task default: [:"db:setup", :test, :server_test]
19+
task default: :test

sorbet/rbi/shims/server_test.rbi

Lines changed: 0 additions & 11 deletions
This file was deleted.

test/ruby_lsp_rails/server_test.rb

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,9 @@
11
# typed: true
22
# frozen_string_literal: true
33

4-
# Configure Rails Environment
5-
ENV["RAILS_ENV"] = "test"
6-
require_relative "../dummy/config/environment"
7-
8-
require "minitest/autorun"
9-
require "mocha/minitest"
4+
require "test_helper"
105
require "ruby_lsp/ruby_lsp_rails/server"
116

12-
if defined?(T)
13-
puts "T is defined, indicating that sorbet-runtime was loaded"
14-
puts "This test should run without sorbet-runtime"
15-
exit(1)
16-
end
17-
187
class ServerTest < ActiveSupport::TestCase
198
setup do
209
@stdout = StringIO.new
@@ -257,7 +246,8 @@ def print_it!
257246
end
258247
end
259248

260-
server.print_it!
249+
server #: as untyped
250+
.print_it!
261251

262252
assert_match("Content-Length: 70\r\n\r\n", stderr.string)
263253
assert_match(

0 commit comments

Comments
 (0)