Encoding performance #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default string literals to be encoded as `ascii-8bit` so we can avoid calling `.b` on string literals. Also change string literals to be mutable so we can avoid calling `.dup` on string literal buffers.
|
It's a bit surprising that time is so dominated by string concat that it dwarfs everything else so completely. Would be curious to see profiling data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default string literals to be encoded as
ascii-8bitso we can avoid calling.bon string literals. Also change string literals to be mutable so we can avoid calling.dupon string literal buffers.This should reduce method calls, but I didn't see any change in performance. I suspect that since the time is being dominated by
String#<<this won't make much difference until we better supportString#<<in YJITcc @nirvdrum