Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

Commit 7fa6deb

Browse files
authored
Fix broken css build error caused by Frame (#11917)
### WHY are these changes introduced? Fixes #11784 ### WHAT is this pull request doing? Print css wasn't working here, the nesting was odd. To tophat go to render settings in dev tools and emulate print media in prod or storybook. ![image](https://github.com/Shopify/polaris/assets/6844391/3e1b0a53-5dc5-4d94-be83-151003856ae3) ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
1 parent 993e312 commit 7fa6deb

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

.changeset/early-pens-hide.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/polaris': patch
3+
---
4+
5+
Fixed broken css build error

polaris-react/src/components/Frame/Frame.module.css

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,6 @@
221221
.hasNav & {
222222
/* stylelint-disable-next-line -- polaris custom global property */
223223
padding-left: var(--pg-layout-width-nav-base);
224-
@media print {
225-
padding-left: 0;
226-
}
227224
/* stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY */
228225
@mixin safe-area-for padding-left, var(--pg-layout-width-nav-base), left;
229226
}
@@ -236,6 +233,12 @@
236233
padding-top: 0;
237234
}
238235
}
236+
237+
@media print {
238+
.hasNav & {
239+
padding-left: 0;
240+
}
241+
}
239242
}
240243

241244
.Main-TopBarAndReframe {

0 commit comments

Comments
 (0)