Skip to content

Commit 311b465

Browse files
committed
escape all db values
1 parent afd2565 commit 311b465

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

benchmarks/microbench/bulk_select_indexed.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func (c *BulkSelectIndexed) NewContextData(conn *mybench.Connection) (MicroBench
3636
var err error
3737
contextData := MicroBenchContextData{}
3838

39-
query := fmt.Sprintf("SELECT * FROM %s WHERE idx2 = ?", c.table.Name)
39+
query := fmt.Sprintf("SELECT * FROM `%s` WHERE idx2 = ?", c.table.Name)
4040
contextData.Statement, err = conn.Prepare(query)
4141
return contextData, err
4242
}

benchmarks/microbench/bulk_select_indexed_order.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func (c *BulkSelectIndexedOrder) NewContextData(conn *mybench.Connection) (Micro
3838
var err error
3939
contextData := MicroBenchContextData{}
4040

41-
query := fmt.Sprintf("SELECT * FROM %s WHERE idx2 = ? ORDER BY %s", c.table.Name, c.orderField)
41+
query := fmt.Sprintf("SELECT * FROM `%s` WHERE idx2 = ? ORDER BY `%s`", c.table.Name, c.orderField)
4242
contextData.Statement, err = conn.Prepare(query)
4343
return contextData, err
4444
}

benchmarks/microbench/point_select.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func (c *PointSelect) NewContextData(conn *mybench.Connection) (MicroBenchContex
5151
var err error
5252
contextData := MicroBenchContextData{}
5353

54-
query := fmt.Sprintf("SELECT * FROM %s WHERE %s", c.table.Name, clause)
54+
query := fmt.Sprintf("SELECT * FROM `%s` WHERE %s", c.table.Name, clause)
5555
contextData.Statement, err = conn.Prepare(query)
5656
return contextData, err
5757
}

benchmarks/tutorialbench/workload_read_latest_chirps.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ type ReadLatestChirps struct {
1313
}
1414

1515
func (w *ReadLatestChirps) Event(ctx mybench.WorkerContext[mybench.NoContextData]) error {
16-
query := fmt.Sprintf("SELECT * FROM %s ORDER BY created_at DESC LIMIT 200", w.table.Name)
16+
query := fmt.Sprintf("SELECT * FROM `%s` ORDER BY created_at DESC LIMIT 200", w.table.Name)
1717
_, err := ctx.Conn.Execute(query)
1818
return err
1919
}

benchmarks/tutorialbench/workload_read_single_chirp.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ func (w *ReadSingleChirp) Event(ctx mybench.WorkerContext[ReadSingleChirpContext
2525
func (w *ReadSingleChirp) NewContextData(conn *mybench.Connection) (ReadSingleChirpContext, error) {
2626
var err error
2727
ctx := ReadSingleChirpContext{}
28-
ctx.stmt, err = conn.Prepare(fmt.Sprintf("SELECT * FROM %s WHERE id = ?", w.table.Name))
28+
ctx.stmt, err = conn.Prepare(fmt.Sprintf("SELECT * FROM `%s` WHERE id = ?", w.table.Name))
2929
return ctx, err
3030
}
3131

data_generators.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ func NewUniqueStringGeneratorFromDatabase(databaseConfig DatabaseConfig, table,
476476
}
477477
defer conn.Close()
478478

479-
query := fmt.Sprintf("SELECT MIN(CAST(SUBSTRING_INDEX(%s, '!', 1) AS UNSIGNED)) AS min_value, MAX(CAST(SUBSTRING_INDEX(%s, '!', 1) AS UNSIGNED)) AS current_value FROM %s.%s", column, column, databaseConfig.Database, table)
479+
query := fmt.Sprintf("SELECT MIN(CAST(SUBSTRING_INDEX(%s, '!', 1) AS UNSIGNED)) AS min_value, MAX(CAST(SUBSTRING_INDEX(%s, '!', 1) AS UNSIGNED)) AS current_value FROM `%s`.`%s`", column, column, databaseConfig.Database, table)
480480
res, err := conn.Execute(query)
481481
if err != nil {
482482
return nil, err
@@ -492,7 +492,7 @@ func NewUniqueStringGeneratorFromDatabase(databaseConfig DatabaseConfig, table,
492492
return nil, err
493493
}
494494

495-
query = fmt.Sprintf("SELECT LENGTH(`%s`) FROM %s.%s LIMIT 1", column, databaseConfig.Database, table)
495+
query = fmt.Sprintf("SELECT LENGTH(`%s`) FROM `%s`.`%s` LIMIT 1", column, databaseConfig.Database, table)
496496
res, err = conn.Execute(query)
497497
if err != nil {
498498
return nil, err
@@ -694,7 +694,7 @@ func NewAutoIncrementGeneratorFromDatabase(databaseConfig DatabaseConfig, table,
694694
}
695695
defer conn.Close()
696696

697-
query := fmt.Sprintf("SELECT MIN(%s), MAX(%s) FROM %s.%s", column, column, databaseConfig.Database, table)
697+
query := fmt.Sprintf("SELECT MIN(%s), MAX(%s) FROM`%s`.`%s`", column, column, databaseConfig.Database, table)
698698
res, err := conn.Execute(query)
699699
if err != nil {
700700
return nil, err

0 commit comments

Comments
 (0)