New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find currency by symbols when currency is not a valid iso4217 format #340

Open

metamoni opened this issue Oct 9, 2024 · 1 comment

Assignees

metamoni commented Oct 9, 2024

When a currency is passed in a format other than iso4217, provide a way to find it by one of the alternate symbols.

metamoni self-assigned this

Contributor

elfassy commented Oct 9, 2024 •

edited

Loading

Here's a POC PR https://github.com/Shopify/money/pull/341/files. I went for an option on find

Money::Currency.find("US$", match_symbols: true)

Let me know if you like this approach, we can add the missing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment